Skip to content

fix(vue-query): make vue-query client compatible with query-core #9250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 4, 2025
Merged

fix(vue-query): make vue-query client compatible with query-core #9250

merged 2 commits into from
Jun 4, 2025

Conversation

DamianOsipiuk
Copy link
Contributor

Make vue-query client compatible on type level with query-core.

Also adjusted code to conditionally access isRestoring flag.

Caution

A note here is that while compatible, using query-core client would drop some vue specific optimizations.

closes: #8937

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 4, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 3c6be86.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 59s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 23s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-04 18:17:09 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jun 4, 2025

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9250

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9250

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9250

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9250

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9250

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9250

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9250

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9250

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9250

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9250

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9250

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9250

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9250

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9250

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9250

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9250

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9250

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9250

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9250

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9250

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9250

commit: 3c6be86

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2025

Sizes for commit 3c6be86:

Branch Bundle Size
Main
This PR

@codecov Codecov
Copy link

codecov bot commented Jun 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.10%. Comparing base (838acec) to head (3c6be86).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #9250       +/-   ##
===========================================
+ Coverage   45.29%   71.10%   +25.80%     
===========================================
  Files         207       19      -188     
  Lines        8264      481     -7783     
  Branches     1854      139     -1715     
===========================================
- Hits         3743      342     -3401     
+ Misses       4080      109     -3971     
+ Partials      441       30      -411
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/query-test-utils ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query 71.10% <100.00%> (+0.24%) ⬆️
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DamianOsipiuk DamianOsipiuk merged commit fc92ef9 into main Jun 4, 2025
7 checks passed
@DamianOsipiuk DamianOsipiuk deleted the do/vue-query-client-compatible-with-core branch June 4, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: vue-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to use Core QueryClient as Custom Query Client in Vue
1 participant
@DamianOsipiuk