fix(solid-query-devtools): client-side code instantiating prematurely server-side #9163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlemahieu
changed the title
wlemahieu
changed the title
wlemahieu
commented
May 19, 2025
| @@ -1,5 +1,5 @@ | |||
| import { isDev } from 'solid-js/web' | |||
| import { clientOnly } from './devtools' | |||
| import clientOnly from './clientOnly' | |||
There was a problem hiding this comment.
The problem is here, importing from ./devtools prematurely before line 6 dynamically imports it later.
|
@birkskyum could you please have a look? |
wlemahieu
commented
May 31, 2025
| @@ -0,0 +1,43 @@ | |||
| import { | |||
There was a problem hiding this comment.
No changes were made here. Just moving clientOnly to it's own file.
wlemahieu
changed the title
wlemahieu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug reported here.
Reproducible example here.
User experience problem:
When using the
Tanstack Solid-Startapp, trying to use theSolidQueryDevtoolscomponent renders[object Promise]instead of the actual devtools UI.Technical problem:
Importing
clientOnlyfrom the same module as the one that's being dynamically imported (./devtools) throughclientOnlycauses client-side code to be executed on the server-side. Particularly, thesolid-js/weblibrary seems to be the cause.The solution:
Simply separate the
clientOnly()logic from thedevtools.tsxlogic. This separates concerns between each component's imports. Now the imports for devtools only load dynamically once, not twice (once prematurely) through importing clientOnly from the same file.Before UI
After UI