Skip to content

test(react-query): resolve ESLint typescript-eslint/require-await warnings for queryOptions.test-d.tsx #8907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 1, 2025
Merged

test(react-query): resolve ESLint typescript-eslint/require-await warnings for queryOptions.test-d.tsx #8907

merged 2 commits into from
Apr 1, 2025

Conversation

minseong0324
Copy link
Contributor

Fix ESLint warnings for async functions without await

Resolved ESLint "require-await" warnings throughout the test files by:

  • Removing unnecessary async keywords where no await is used
  • Using Promise.resolve() to explicitly return promises instead

These changes don't affect functionality but make the linter happy and improve code clarity.

ref: #8887 (comment)

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 31, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 982e927.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ❌ Failed 5m 33s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 32s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-01 06:31:21 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Mar 31, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8907

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8907

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8907

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8907

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8907

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8907

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8907

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8907

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8907

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8907

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8907

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8907

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8907

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8907

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8907

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8907

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8907

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8907

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8907

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8907

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8907

commit: 982e927

@TkDodo TkDodo merged commit 78c8a0c into TanStack:main Apr 1, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: react-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minseong0324 @TkDodo