Skip to content

update to vite 6 #8896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 2, 2025
Merged

Conversation

birkskyum
Copy link
Member

@birkskyum birkskyum commented Mar 31, 2025

Closes #8799
Supersedes #8816

Updates in tests/examples/integrations/devDeps
@vitejs/plugin-react -> patch update
vite 5 -> 6
svelte and svelte vite plugin -> v5
angular 17/19 prerelease -> 19 stable release
vitest 2 -> 3
typescript -> 5.8.2

Copy link

nx-cloud bot commented Mar 31, 2025

View your CI Pipeline Execution ↗ for commit 986d7e2.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 41s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-02 09:43:14 UTC

Copy link
Collaborator

@TkDodo TkDodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you update vite everywhere so that we only have one version of vite in the repo ?

@birkskyum
Copy link
Member Author

birkskyum commented Mar 31, 2025

I've updated the astro example to vite 6.

The only remaining vite 5 usage comes from the angular-cli-17 integration (@angular-devkit/build-angular) which use vite 5.x underneath

@birkskyum birkskyum changed the title bump solid-start-streaming example to latest update to vite 6 Mar 31, 2025
Copy link

pkg-pr-new bot commented Apr 1, 2025

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8896

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8896

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8896

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8896

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8896

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8896

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8896

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8896

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8896

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8896

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8896

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8896

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8896

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8896

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8896

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8896

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8896

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8896

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8896

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8896

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8896

commit: 986d7e2

Copy link

github-actions bot commented Apr 1, 2025

Sizes for commit 986d7e2:

Branch Bundle Size
Main
This PR

Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.07%. Comparing base (24dd7c7) to head (986d7e2).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8896      +/-   ##
==========================================
+ Coverage   44.02%   44.07%   +0.04%     
==========================================
  Files         200      200              
  Lines        8016     8021       +5     
  Branches     1771     1769       -2     
==========================================
+ Hits         3529     3535       +6     
- Misses       4057     4058       +1     
+ Partials      430      428       -2     
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 88.08% <ø> (ø)
@tanstack/eslint-plugin-query 87.81% <ø> (ø)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods 0.00% <ø> (ø)
@tanstack/query-core 94.77% <50.00%> (ø)
@tanstack/query-devtools 3.61% <ø> (ø)
@tanstack/query-persist-client-core 57.73% <ø> (ø)
@tanstack/query-sync-storage-persister 84.61% <ø> (ø)
@tanstack/react-query 95.42% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.20% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 88.15% <ø> (+0.82%) ⬆️
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 71.01% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@birkskyum birkskyum requested a review from TkDodo April 2, 2025 01:47
@birkskyum
Copy link
Member Author

birkskyum commented Apr 2, 2025

@TkDodo , I've updated vite everywhere, but it took a few more things with it to do so. I don't know if maybe it would be safest to do a major bump, as many others libraries have done for vite 6, because i think some vite 5 compatibility could be lost in the process, as a result of the breaking changes in vite 6.

@TkDodo
Copy link
Collaborator

TkDodo commented Apr 2, 2025

We don't use vite for bundling so why would it be breaking for consumers?

@birkskyum
Copy link
Member Author

That's a good point - it's just examples, tests and integrations that's updated

@birkskyum birkskyum merged commit 8e27629 into main Apr 2, 2025
7 checks passed
@birkskyum birkskyum deleted the bump-solid-start-streaming-example-to-latest branch April 2, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment