-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
update to vite 6 #8896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to vite 6 #8896
Conversation
View your CI Pipeline Execution ↗ for commit 986d7e2.
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you update vite everywhere so that we only have one version of vite in the repo ?
I've updated the astro example to vite 6. The only remaining vite 5 usage comes from the angular-cli-17 integration ( |
b5452cc
to
e7a7aa0
Compare
Sizes for commit 986d7e2:
|
ed973f8
to
f995f32
Compare
c33432e
to
790ea68
Compare
790ea68
to
1aa9ca5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8896 +/- ##
==========================================
+ Coverage 44.02% 44.07% +0.04%
==========================================
Files 200 200
Lines 8016 8021 +5
Branches 1771 1769 -2
==========================================
+ Hits 3529 3535 +6
- Misses 4057 4058 +1
+ Partials 430 428 -2 🚀 New features to boost your workflow:
|
@TkDodo , I've updated vite everywhere, but it took a few more things with it to do so. I don't know if maybe it would be safest to do a major bump, as many others libraries have done for vite 6, because i think some vite 5 compatibility could be lost in the process, as a result of the breaking changes in vite 6. |
We don't use vite for bundling so why would it be breaking for consumers? |
That's a good point - it's just examples, tests and integrations that's updated |
Closes #8799
Supersedes #8816
Updates in tests/examples/integrations/devDeps
@vitejs/plugin-react -> patch update
vite 5 -> 6
svelte and svelte vite plugin -> v5
angular 17/19 prerelease -> 19 stable release
vitest 2 -> 3
typescript -> 5.8.2