refactor: split QtDriver into View and Controller to follow MVC model #935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Computerdores
added
the
Status: Blocked
Computerdores
added
the
Type: Refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Splits the View aspects out of
QtDriverinto the existing Main Window class so that only the Control aspects remain.This will reduce the size of
ts_qt.pyand should generally make the code more maintainable.Note: This is based off of #933 as that PR also modifies
ts_qt.pyand merging afterwards would be a pain.(which also means that atm the #933 commits show up in this PR as well)
Tasks Completed