[BUGFIX] Add check if generator is valid before traversing it #4283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobsenj
force-pushed
the
jacobsenj-cannot-traverse-an-already-closed-generator
branch
from
da2f122 to
b2cbeae
Compare
|
All methods in SiteRepository using the result from $siteGenerator = $this->getAvailableTYPO3ManagedSites($stopOnInvalidSite);have to test against If this is done, the patch is OK for me. Stefan |
If there's no solr configuration for any site, saving pages or content results in a PHP exception: Uncaught TYPO3 Exception: Cannot traverse an already closed generator | Exception thrown in file .../Classes/Domain/Site/SiteRepository.php in line 135 The added check prevents this error.
jacobsenj
force-pushed
the
jacobsenj-cannot-traverse-an-already-closed-generator
branch
from
b2cbeae to
947336b
Compare
|
I've added the checks for the remaining three calls. |
sfroemkenjw
approved these changes
Jan 23, 2025
|
I also got hit by that bug. Any chance to get this merged and a patchlevel release out soon-ish? |
|
@andreaswolf |
dkd-kaehm
pushed a commit
to dkd-kaehm/ext-solr
that referenced
this pull request
Jan 28, 2025
If there's no solr configuration for any site, saving pages or content results in a PHP exception: Uncaught TYPO3 Exception: Cannot traverse an already closed generator | Exception thrown in file .../Classes/Domain/Site/SiteRepository.php in line 135 The added check prevents this error. Fixes: TYPO3-Solr#4284 Ports: TYPO3-Solr#4283
dkd-kaehm
pushed a commit
that referenced
this pull request
Jan 29, 2025
If there's no solr configuration for any site, saving pages or content results in a PHP exception: Uncaught TYPO3 Exception: Cannot traverse an already closed generator | Exception thrown in file .../Classes/Domain/Site/SiteRepository.php in line 135 The added check prevents this error. Fixes: #4284 Ports: #4283
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there's no solr configuration for any site, saving pages or content results in a PHP exception:
Uncaught TYPO3 Exception: Cannot traverse an already closed generator | Exception thrown in file .../Classes/Domain/Site/SiteRepository.php in line 135
The added check prevents this error.
Fixes: #4284