enhance CompositeArchRule.of

[sullis]

• new method: of(Collection)

[sullis]

WDYT? @codecholeric

[codecholeric]

Thanks a lot for the PR! 😃 The only thing I'm wondering is: Wouldn't a single method that takes an Iterable<ArchRule> be sufficient? It would also swallow Collection<ArchRule> then. But I can't really imagine a scenario where one would only have an Iterator<ArchRule> 🤔 That's not a type you usually really use, is it?

[sullis]

Thanks a lot for the PR! 😃 The only thing I'm wondering is: Wouldn't a single method that takes an Iterable<ArchRule> be sufficient? It would also swallow Collection<ArchRule> then. But I can't really imagine a scenario where one would only have an Iterator<ArchRule> 🤔 That's not a type you usually really use, is it?

I removed of(Iterator). I plan to use of(Collection) is one my internal projects.

[sullis]

@codecholeric WDYT?

[codecholeric]

Cool, thanks a lot 😃 I made the method take an Iterable with a covariant type, cause I thought it's even more flexible then (and doesn't cause any harm for your use case 😉)

[sullis]

@codecholeric are there any plans to release a new version of ArchUnit? (This PR was completed in July but there has not been any releases since May)

[sullis]

@codecholeric are there any plans to release a new version of ArchUnit? (This PR was completed in July 2020 but there have not been any releases since May 2020)

[codecholeric]

Yes, I know I'm super slow this time 😞 In short, yes, I'm waiting for a review on #484 and I want to implement the counter part of #428 to not have a difference between dependencies from self and to self. I actually planned to release this weekend, but didn't completely make it. Need to make sure to release quicker iterations in the future, this time the interval really is way too big 😞