Use manifest.mf from maven's $(project.basedir) instead of the 1st <packaging:module> in tibco.xml #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<packaging:module> in tibco.xml
RajibBiswasTibco
added a commit
that referenced
this pull request
Jun 12, 2017
|
Included this PR in Release Version 1.2.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using pom.xml with multiple source code modules, the generated ear file does not always have the right version in the manifest. (It currently use the version of the 1st packaging:module of the tibco.xml)
Ex:
pom.xml defines 2 modules:
app.bwsm - v1.1.0
app.bwapp - v1.0.0
We expected the manifest of app.bwapp to be v1.0.0 but it was v1.1.0 because of the order define in TIBCO.xml
This patch uses manifest.mf that is currently in project.basedir