Skip to content

Add dynamic width for large-ish screens #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Add dynamic width for large-ish screens #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions dynamic/css/abstracts/_configurations.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,12 @@
// To hide an element on 'lg' or larger,
// <div class="hidden-lg-up"></div>

$xs-screen-min: 20.0rem; // 320px
$sm-screen-min: 30.0rem; // 480px
$md-screen-min: 48.0rem; // 768px
$lg-screen-min: 66.5rem; // 1064px
$xl-screen-min: 86.0rem; // 1376px

$xs-screen-min: 20.0rem; // 320px
$sm-screen-min: 30.0rem; // 480px
$md-screen-min: 48.0rem; // 768px
$lg-screen-min: 66.5rem; // 1064px
$xl-screen-min: 86.0rem; // 1376px
$vl-screen-min: 172.0rem; // 2752px -- aka VERY large


// Vendor Configuration Overrides
Expand Down Expand Up @@ -75,6 +75,7 @@ $grid-breakpoints: (
md: $md-screen-min,
lg: $lg-screen-min,
xl: $xl-screen-min,
vl: $vl-screen-min,
);


Expand All @@ -83,10 +84,11 @@ $grid-breakpoints: (
// Define the maximum width of `.container` for different screen sizes.

$container-max-widths: (
sm: 32rem, // 512px
md: 45rem, // 720px
lg: 58.75rem, // 940px
xl: 71.25rem, // 1140px
sm: 32rem, // 512px
md: 45rem, // 720px
lg: 58.75rem, // 940px
xl: 71.25rem, // 1140px
vl: 157.25rem, // 2516px
);


Expand Down
16 changes: 13 additions & 3 deletions dynamic/css/layout/_banner.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ $banner-logo-width-md-up : p2r(163px);

// Intra-Brand/-Site navigation pane
$navigation-pane-width-lg : $content-well-width-lg - $banner-logo-width-md-up - $banner-padding-left-md-up;
$navigation-pane-width-xl : $content-well-width-xl - $banner-logo-width-md-up - $banner-padding-left-md-up;
$navigation-pane-width-xl-edge : $content-well-width-xl-edge;
$navigation-pane-width-vl : $content-well-width-vl - $banner-logo-width-md-up - $banner-padding-left-md-up;

// Intra-Brand navigation element
$intra-brand-height : 2.0rem;
Expand Down Expand Up @@ -166,7 +167,12 @@ $banner-background-secondary : $gray-45;

@include wide-from('xl') {
padding-left : 13.5rem;
max-width : $navigation-pane-width-xl; /* 3 */
max-width: calc(100% - #{$navigation-pane-width-xl-edge}); /* 3 */
}

@include wide-from('vl') {
padding-left : 13.5rem;
max-width : $navigation-pane-width-vl; /* 3 */
}

@include when-inside('.index') {
Expand Down Expand Up @@ -251,7 +257,11 @@ $banner-background-secondary : $gray-45;
}

@include wide-from('xl') {
max-width : $navigation-pane-width-xl; /* 2 */
max-width : calc(100% - #{$navigation-pane-width-xl-edge}); /* 2 */
}

@include wide-from('vl') {
max-width : $navigation-pane-width-vl; /* 2 */
}
}
.banner__intra-site {
Expand Down
17 changes: 13 additions & 4 deletions dynamic/css/layout/_wireframe.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,18 +45,20 @@ $content-nav-padding-left : 1.0rem;
$content-nav-padding-right-md : 2.0rem;
$content-nav-padding-right-lg : 3.0rem;
$content-nav-padding-right-xl : 4.5rem;
$content-nav-padding-right-vl : 4.5rem;
$content-nav-padding-bottom : 2.0rem;

// Main-Article fixed-widths
$main-article-width-md : 46.5rem;
$main-article-width-lg : 46.5rem;
$main-article-width-xl : 57.5rem;
$main-article-width-xl-edge : 8rem;
$main-article-width-vl : 115rem;

// Aggregate Content-Well fixed-width
$content-well-width-md : $content-nav-padding-left + $content-nav-width-md + $content-nav-padding-right-md + $main-article-width-md;
$content-well-width-lg : $content-nav-padding-left + $content-nav-width-lg-up + $content-nav-padding-right-lg + $main-article-width-lg;
$content-well-width-xl : $content-nav-padding-left + $content-nav-width-lg-up + $content-nav-padding-right-xl + $main-article-width-xl;

$content-well-width-vl : $content-nav-padding-left + $content-nav-width-lg-up + $content-nav-padding-right-xl + $main-article-width-vl;
$content-well-width-xl-edge : $main-article-width-xl-edge;


// Z-Indexes of layered elements
Expand Down Expand Up @@ -170,7 +172,14 @@ $main-z-index : 100;
padding-left : ($content-nav-width-lg-up
+ $content-nav-padding-left
+ $content-nav-padding-right-xl); /* 1, 3 */
max-width : $content-well-width-xl;
max-width: calc(100% - #{$main-article-width-xl-edge});
}

@include wide-from('vl') {
padding-left : ($content-nav-width-lg-up
+ $content-nav-padding-left
+ $content-nav-padding-right-vl); /* 1, 3 */
max-width : $content-well-width-vl;
}

&.content-well--immobile {
Expand Down