Skip to content

Add DOSBox Windows Support #4294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 44 commits into from
Apr 30, 2025

Conversation

SergioMartin86
Copy link
Contributor

@SergioMartin86 SergioMartin86 commented Apr 20, 2025

Pull request to improve the way hard disk drives are handled and facilitate the creation of windows images

  • Fix function naming to PascalCase
  • Add support and verification movie for Windows 3.1
  • Add support and verification movie for Windows 95
  • Add support and verification movie for Windows 98
  • Add HDD dumping option
  • Proper GUI placement of HDD Export
  • Fix issue [DOS] BizHawk crashes on the next session after preserving a high-volume HDD #4296
  • Fix issue where the core reported cumulative timing, instead of per-frame timing
  • Increased priority of DOSBox formats over unsupported cores in disc detection logic

Optional:

  • Add support for Windows 2000 (won't initiate setup)
  • Add support for Windows XP (will fail during file copying phase)

Check if completed:

@vadosnaprimer
Copy link
Contributor

Context #3951.

@SergioMartin86 SergioMartin86 marked this pull request as ready for review April 25, 2025 16:15
@YoshiRulz YoshiRulz self-requested a review April 25, 2025 21:07
Copy link
Member

@YoshiRulz YoshiRulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

Copy link
Contributor

@nattthebear nattthebear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all seems to make sense to me; in particular, the usage of waterbox VFS should all be correct.

@vadosnaprimer vadosnaprimer merged commit e04fd79 into TASEmulators:master Apr 30, 2025
6 checks passed
@vadosnaprimer
Copy link
Contributor

Thanks again for all the work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOS] BizHawk crashes on the next session after preserving a high-volume HDD
5 participants