Adding PPSSPP as ported emulation core for Sony PSP #4284

SergioMartin86 · 2025-04-06T10:00:05Z

Adding https://github.com/TASEmulators/ppsspp/tree/ported as new ported core in Bizhawk

Check if completed:

I have run any relevant test suites
I, the committer, have read the licensing terms for contributors (last updated 2024-06-22) and am compliant

This reverts commit 9a2b83f.

…one" This reverts commit c6690c8.

SergioMartin86 · 2025-04-13T08:06:14Z

The core is now mostly functional and I reduced the diff wrt upstream the most I could.

Still, there seems to be some games (Crash Tag Team Racing (US).iso) that fail to load. These games DO work on my headless playerhttps://github.com/SergioMartin86/headlessPPSSPP, so no idea why putting this into bizhawk could be a problem.

I haven't figured out how NVRAM is saved so that is still pending.

vadosnaprimer · 2025-04-13T08:09:08Z

.gitmodules

@@ -89,3 +89,12 @@
 	path = waterbox/dsda/core
 	url = https://github.com/TASEmulators/dsda-doom.git
 	branch = wbx
+[submodule "waterbox/ppsspp/ppsspp"]
+	path = ppsspp/ppsspp
+	url = https://github.com/TASEmulators/ppsspp.git


Which branch?

It's better to always keep hawk specific changes rebased on top of upstream branch that we rely on. And each time we pull upstream and rebase anew we would increment our branch version like this: wbx-1, wbx-2, etc, so every rebase is a new branch, because it basically changes history, which we want to preserve it on every update. This is better than merging upsream changes because that makes our changes harder to find over time.

And yeah please explicitly put the branch into this file, that way it's clear where the code is coming from. Only pointing to commit can result in detached head and that commit can belong to different branches, making future maintenance more annoying.

I can see the wbx branch in the repo now but not in .gitmodules...

Uh, this is strange. This core isn't wbxed; it's ported. This every must be a residual from when I tried to wbx it

Ah LOL indeed. Then the usual name for it is bizhawk.

Spikestuff · 2025-04-13T11:27:02Z

I truncated out the issues from my above post.
Just read the History for what's been fixed (good shit eien).

In terms of new issues (by the autobuilds here). Using f1a8d12.
The major one besies the wrong font is being called compared to PPSSPP for some reason.
Is that the "™" is missing from "Memory Stick™":

Compared to PPSSPP:

And according to KAGE-008 at the very least this font issue affects Ghost in the Shell, Assassin's Creed Bloodlines, Crimson Room: Reverse, Jeanne D'Arc and Dissidia.

I was able to validate this missing text issue with Crimson Room: Reverse.

Another title having issues beside Crash Tag Team Racing is Xyanide Resurrection according to KAGE-008 as well.
You're able to boot into the game, but you land into a loading loop before the gameplay starts.

And I just noticed that there's "Right Analog" controls.
PSP only had a single analog stick.

And you're currently unable to access PSP > Settings.

(At least all these are issues with autobuilds)

YoshiRulz · 2025-04-13T11:33:13Z

Missing glyphs aside, could the difference in font metrics cause any problems? Would a scrollbar appear if the message was slightly longer?

Spikestuff · 2025-04-13T11:35:58Z

I don't believe it would be a situation where for example you're missing the Japanese Locale and the entire game would run differently.
But I also haven't run into a situation where it might have happened to me.

SergioMartin86 · 2025-04-15T17:53:24Z

Regarding unstability for some games. I suspect there is some memory corruption that causes issues on Bizhawk+Windows. When running the core on my own driver (https://github.com/SergioMartin86/headlessPPSSPP), it works perfectly for the games that crash

InfamousKnight · 2025-04-21T00:08:17Z

I'm curios why this is not waterboxed. I know waterbox would affect performance, but I don't like tasing while worrying about desyncs.

SergioMartin86 · 2025-04-23T14:57:19Z

I'm curios why this is not waterboxed. I know waterbox would affect performance, but I don't like tasing while worrying about desyncs.

The interpreter crashes when waterboxed. We don't know exactly why, but for now a waterboxed implementation is out of the question. The core seems to have solid load/save state procedures so I'm confident it can still be used ported directly.

YoshiRulz · 2025-05-12T14:42:35Z

src/BizHawk.Emulation.Cores/Consoles/Sony/PSP/PPSSPP.ISettable.cs

+
+namespace BizHawk.Emulation.Cores.Consoles.Sony.PSP
+{
+	public partial class PPSSPP : ISettable<PPSSPP.Settings, PPSSPP.SyncSettings>


If there are no settings, use ISettable<object, ...>, and likewise for sync settings, and if there are neither then I think you can just omit the interface.

YoshiRulz · 2025-05-12T14:45:00Z

src/BizHawk.Emulation.Cores/Consoles/Sony/PSP/PPSSPP.IStatable.cs

+
+			var stateLen = reader.ReadInt32();
+
+			if (stateLen > _stateBuf.Length)


YoshiRulz · 2025-05-12T14:45:23Z

src/BizHawk.Emulation.Cores/Consoles/Sony/PSP/PPSSPP.IStatable.cs

+			var stateLen = _libPPSSPP.GetStateSize();
+			writer.Write(stateLen);
+
+			if (stateLen > _stateBuf.Length)


Should this be !=? Under what circumstances could this happen?

YoshiRulz · 2025-05-12T14:45:59Z

src/BizHawk.Emulation.Cores/Consoles/Sony/PSP/PPSSPP.IVideoProvider.cs

+
+		protected readonly IntPtr _context;
+
+		public PPSSPP(LibPPSSPP core, IntPtr context)


core argument is ignored? This constructor doesn't seem to be used anyway.

YoshiRulz · 2025-05-12T14:48:02Z

src/BizHawk.Emulation.Cores/Consoles/Sony/PSP/PPSSPP.cs

+			string resourceName = "";
+
+			resourceName = "compat.ini";
+			var compatIniData = new MemoryStream(Resources.PPSSPP_COMPAT_INI.Value).ToArray();


Would this work for these?

Suggested change

var compatIniData = new MemoryStream(Resources.PPSSPP_COMPAT_INI.Value).ToArray();

var compatIniData = Resources.PPSSPP_COMPAT_INI.Value.ReadAllBytes();

YoshiRulz · 2025-05-12T14:51:58Z

src/BizHawk.Emulation.Cores/Consoles/Sony/PSP/PPSSPP.cs

+			_serviceProvider.Register<ISoundProvider>(this);
+
+			// Loading LibPPSSPP
+			_resolver?.Dispose();


This is the constructor—this field is definitely null here.

SergioMartin86 and others added 23 commits March 30, 2025 21:27

Adding base

3469daa

progress

e13a90e

Building

734b8b6

Fixing memareas

35e7097

Adding base

308489d

Progress

f2f676b

updates to bizhawk

cc6dcc6

Taking ppsspp out of waterbox, trying to run it ported

5e814a4

renaming old implementation to _wbx before adding the ported one

c6690c8

creating adapted psp

9a2b83f

Revert "creating adapted psp"

dcee9e7

This reverts commit 9a2b83f.

Revert "renaming old implementation to _wbx before adding the ported …

18e3cea

…one" This reverts commit c6690c8.

Reverting some changes, removing waterbox base class

54cd643

Stable base for new PPSSPP core

0248846

Added msvc

ffc9bee

[WIP] working on windows compilation

1c6b245

Compiling but still not linking

31f0e68

Progress

c355b96

Producing dll

a6307dd

Progress

c9f40dd

ported running

201234a

Now running on windows with ffmpeg

fffac3d

Updating ppsspp

8db0c7c

Spikestuff mentioned this pull request Apr 6, 2025

[Core Port Req.] PPSSPP - PlayStation Portable #4179

Open

This comment was marked as resolved.

Sign in to view

YoshiRulz linked an issue Apr 6, 2025 that may be closed by this pull request

[Core Port Req.] PPSSPP - PlayStation Portable #4179

Open

SergioMartin86 added 4 commits April 7, 2025 19:36

Progress with ported

884a3a5

updates

42d0ed7

Properly working with myst

8581fdc

Updates

8b4c7ff

SergioMartin86 and others added 9 commits April 12, 2025 16:49

Progress

d141beb

Adding sdl config

55f7c9d

Merge branch 'ppsspp' of github.com:SergioMartin86/BizHawk into ppsspp

5b572e6

Windows now compiling. Font error fixed

b8616ed

built linux

1a554da

Adding UI fonts

4056962

Resync with upstream

00e08dc

Detecting inputs

6c1f272

Updating linux compilation

f1a8d12

SergioMartin86 marked this pull request as ready for review April 13, 2025 08:06

vadosnaprimer reviewed Apr 13, 2025

View reviewed changes

YoshiRulz self-requested a review April 13, 2025 11:10

SergioMartin86 added 2 commits April 15, 2025 19:40

adding sound

5264b63

Added sound

4fe2c00

This comment was marked as resolved.

Sign in to view

This comment was marked as off-topic.

Sign in to view

YoshiRulz added 3 commits May 13, 2025 00:11

Remove unused imports

b09b6bc

Fix line-end whitespace

e20ec72

Use #if false for commented-out code blocks

3ce4368

YoshiRulz requested changes May 12, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding PPSSPP as ported emulation core for Sony PSP #4284

Adding PPSSPP as ported emulation core for Sony PSP #4284

SergioMartin86 commented Apr 6, 2025 •

edited

Loading

This comment was marked as resolved.

SergioMartin86 commented Apr 13, 2025

vadosnaprimer Apr 13, 2025

SergioMartin86 Apr 13, 2025

vadosnaprimer Apr 13, 2025 •

edited

Loading

SergioMartin86 Apr 15, 2025

vadosnaprimer Apr 15, 2025

SergioMartin86 Apr 15, 2025

vadosnaprimer Apr 15, 2025

Spikestuff commented Apr 13, 2025 •

edited

Loading

YoshiRulz commented Apr 13, 2025

Spikestuff commented Apr 13, 2025 •

edited

Loading

SergioMartin86 commented Apr 15, 2025

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as off-topic.

InfamousKnight commented Apr 21, 2025

SergioMartin86 commented Apr 23, 2025 •

edited

Loading

YoshiRulz May 12, 2025

YoshiRulz May 12, 2025

YoshiRulz May 12, 2025

YoshiRulz May 12, 2025

YoshiRulz May 12, 2025

YoshiRulz May 12, 2025


		var stateLen = reader.ReadInt32();

		if (stateLen > _stateBuf.Length)


		protected readonly IntPtr _context;

		public PPSSPP(LibPPSSPP core, IntPtr context)

	var compatIniData = new MemoryStream(Resources.PPSSPP_COMPAT_INI.Value).ToArray();
	var compatIniData = Resources.PPSSPP_COMPAT_INI.Value.ReadAllBytes();

Adding PPSSPP as ported emulation core for Sony PSP #4284

Are you sure you want to change the base?

Adding PPSSPP as ported emulation core for Sony PSP #4284

Conversation

SergioMartin86 commented Apr 6, 2025 • edited Loading

This comment was marked as resolved.

SergioMartin86 commented Apr 13, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vadosnaprimer Apr 13, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Spikestuff commented Apr 13, 2025 • edited Loading

YoshiRulz commented Apr 13, 2025

Spikestuff commented Apr 13, 2025 • edited Loading

SergioMartin86 commented Apr 15, 2025

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as off-topic.

InfamousKnight commented Apr 21, 2025

SergioMartin86 commented Apr 23, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SergioMartin86 commented Apr 6, 2025 •

edited

Loading

vadosnaprimer Apr 13, 2025 •

edited

Loading

Spikestuff commented Apr 13, 2025 •

edited

Loading

Spikestuff commented Apr 13, 2025 •

edited

Loading

SergioMartin86 commented Apr 23, 2025 •

edited

Loading