PCE/SGX 1941 BROKEN LATEST DEV BUILD APPVEYOR

Since bizhawk 2.2.2 2 pce games i noticed issues with were fixed but one is now broken

1941 as soon as you start level one the clouds draw funny.

This is not broken in earlier builds.

for anyone else with this problem as a for now solution i went and downloaded the latest mednafen liberto core for super grafx and set bizhawk to load all pce/sgx roms with this core.

waterbox mednafen?!?!?

[alyosha-tas]

I won’t be able to fix this so unassigning myself.

We need someone to either take over or kill off the PCE core.

But it was working in the previous release Get Outlook for Android<https://aka.ms/ghei36>

…

________________________________ From: alyosha-tas <notifications@github.com> Sent: Thursday, September 13, 2018 7:23:38 PM To: TASVideos/BizHawk Cc: jjfmz42015; Author Subject: Re: [TASVideos/BizHawk] PCE/SGX 1941 BROKEN LATEST DEV BUILD APPVEYOR (#1203) I won’t be able to fix this so unassigning myself. We need someone to either take over or kill off the PCE core. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#1203 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ARgQZYt1w3njlR3JVJ7fVTpMOe6TAyJeks5uauj6gaJpZM4USjqd>.

[vadosnaprimer]

Just bisect guys!

[Asnivor]

Hmm, bisect really is great. I should use this more often :)

Anyway, this is the breaking commit: aa7cee1

However, at this time I haven't got a clue where to start in trying to fix it....

[alyosha-tas]

unfirtunately I don’t really remember what most of that commit is doing. Sometimes I think that the PCE core works just by chance.

You can uncomment all the console.write stuff though and it should give you some decent diagnostic information. Usually the issues that pop up are related to one of those variables changing.

[Asnivor]

So un-commenting those in VDC.Render.cs does nothing - its a supergrafx game rather than turbografx. So the issue is going to be related to the commit changes made in VDC.cs and/or VPC.cs

I can p*ss about changing things until something may or may not work, but ultimately I don't understand enough about the emulated tech itself at this point. If this commit actually fixed problems in other games, then I will almost certainly introduce regressions that I have no idea how to fix.

I'll probably bow out here now...

[Asnivor]

@jjfmz42015 I believe this should be fixed now. Can you please test in the latest dev build and let us know?

https://ci.appveyor.com/project/zeromus/bizhawk-udexo/build/artifacts