evict savestates on branch update

Author: Morilli

src/BizHawk.Client.Common/movie/interfaces/ITasMovie.cs

@@ -53,5 +53,7 @@ public interface ITasMovie : IMovie, INotifyPropertyChanged, IDisposable
 		void LoadBranch(TasBranch branch);
 
 		void CopyVerificationLog(IEnumerable<string> log);
+
+		bool IsReserved(int frame);
 	}
 }

src/BizHawk.Client.Common/movie/tasproj/TasBranch.cs

@@ -87,6 +87,9 @@ public void Replace(TasBranch old, TasBranch newBranch)
 			newBranch.Uuid = old.Uuid;
 			if (newBranch.UserText.Length is 0) newBranch.UserText = old.UserText;
 			this[index] = newBranch;
+			if (!_movie.IsReserved(old.Frame))
+				_movie.TasStateManager.EvictReserved(old.Frame);
+
 			_movie.FlagChanges();
 		}
 
@@ -116,6 +119,9 @@ public void Replace(TasBranch old, TasBranch newBranch)
 			var result = base.Remove(item);
 			if (result)
 			{
+				if (!_movie.IsReserved(item!.Frame))
+					_movie.TasStateManager.EvictReserved(item.Frame);
+
 				_movie.FlagChanges();
 			}
 

src/BizHawk.Client.Common/movie/tasproj/TasMovie.cs

@@ -340,7 +340,7 @@ private void Markers_CollectionChanged(object sender, System.Collections.Special
 		public void ClearChanges() => Changes = false;
 		public void FlagChanges() => Changes = true;
 
-		private bool IsReserved(int frame)
+		public bool IsReserved(int frame)
 		{
 			// Why the frame before?
 			// because we always navigate to the frame before and emulate 1 frame so that we ensure a proper frame buffer on the screen