fix marker state eviction logic

Morilli · Morilli · commit f20d09c8c1fe · 2025-04-12T22:55:08.000+02:00
yeah this never worked
diff --git a/src/BizHawk.Client.Common/movie/tasproj/TasMovieMarker.cs b/src/BizHawk.Client.Common/movie/tasproj/TasMovieMarker.cs
@@ -206,7 +206,7 @@ public void Add(int frame, string message)
 				return;
 			}
 
-			_movie.TasStateManager.EvictReserved(item.Frame);
+			_movie.TasStateManager.EvictReserved(item.Frame - 1);
 			_movie.ChangeLog.AddMarkerChange(null, item.Frame, item.Message);
 
 			base.Remove(item);
@@ -221,7 +221,7 @@ public void Add(int frame, string message)
 				if (match.Invoke(m))
 				{
 					_movie.ChangeLog.AddMarkerChange(null, m.Frame, m.Message);
-					_movie.TasStateManager.EvictReserved(m.Frame);
+					_movie.TasStateManager.EvictReserved(m.Frame - 1);
 				}
 			}
 

Original file line number	Diff line number	Diff line change
`@@ -206,7 +206,7 @@ public void Add(int frame, string message)`
`206`	`206`	`return;`
`207`	`207`	`}`
`208`	`208`
`209`		`- _movie.TasStateManager.EvictReserved(item.Frame);`
	`209`	`+ _movie.TasStateManager.EvictReserved(item.Frame - 1);`
`210`	`210`	`_movie.ChangeLog.AddMarkerChange(null, item.Frame, item.Message);`
`211`	`211`
`212`	`212`	`base.Remove(item);`
`@@ -221,7 +221,7 @@ public void Add(int frame, string message)`
`221`	`221`	`if (match.Invoke(m))`
`222`	`222`	`{`
`223`	`223`	`_movie.ChangeLog.AddMarkerChange(null, m.Frame, m.Message);`
`224`		`- _movie.TasStateManager.EvictReserved(m.Frame);`
	`224`	`+ _movie.TasStateManager.EvictReserved(m.Frame - 1);`
`225`	`225`	`}`
`226`	`226`	`}`
`227`	`227`