feat: replace notebooks with data service #750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olevski
temporarily deployed
to
renku-ci-gw-750
GitHub Actions
Inactive
leafty
reviewed
Dec 10, 2024
|
You can access the deployment of this PR at https://renku-ci-gw-750.dev.renku.ch |
olevski
force-pushed
the
feat-shutdown-notebooks
branch
from
5e056fc to
43bd924
Compare
olevski
temporarily deployed
to
renku-ci-gw-750
GitHub Actions
Inactive
olevski
temporarily deployed
to
renku-ci-gw-750
GitHub Actions
Inactive
olevski
temporarily deployed
to
renku-ci-gw-750
GitHub Actions
Inactive
olevski
temporarily deployed
to
renku-ci-gw-750
GitHub Actions
Inactive
olevski
temporarily deployed
to
renku-ci-gw-750
GitHub Actions
Inactive
leafty
reviewed
Dec 19, 2024
|
Sorry for dismissing your approval @leafty. Nothing really changed. I just did not see that you already approved. And by habit I resolved the comment and requested the review again. |
leafty
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This routes all requests that go to the notebooks to the data service.
Tested the full suite of PRs for this in a separate PR on the renku repo. Also tested to make sure that sessions launched the old way still appear to anonymous and registered users.