Closes #654. Support JSON-LD on SPARQL endpoints and RDF API routes #655
Conversation
Note: The JSON-LD will not be prettified JSON-LD, it will necessarily be expanded JSON-LD.
RickMoynihan
force-pushed
the
json-ld2
branch
from
327fd6f to
4335e52
Compare
There was a problem hiding this comment.
The code changes look good to me, although I've added a question about some of the test organisation.
I ran this version locally in the drafter REPL and performed the following actions against the API:
- Created a new draftset
- Added data in trig format
- Fetched all the data in json-ld format
- Fetched all data within a single graph in json-ld format
- Submitted a CONSTRUCT query requesting json-ld to the draftset SPARQL endpoint
- Published the draftset
- Submitted a CONSTRUCT query requesting json-ld to the live SPARQL endpoint
All of these stages resulted in the expected results.
| ;; NOTE: query may return statements from system graphs which should be ignored | ||
| (is (set/subset? expected-triples response-triples)))) | ||
|
|
||
| (testing "application/ld+json" |
There was a problem hiding this comment.
Should these two tests be replaced with a loop over the available content types? They appear to be otherwise identical and we could extend it to cover all supported formats.
|
I've created issue #656 to discuss refactoring the tests to cover all supported content types. |
|
Ahh yes I did consider refactoring it to do something like that too. I decided not to do it here, but also because the test errors you get when you're looping over variations make debugging a bit more awkward. Still I think it would be worth doing #656. Will merge, thanks 🙇 |
Note: The JSON-LD will not be prettified JSON-LD, it will necessarily be expanded JSON-LD.