Add task to build and publish docker images #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue #340 - Add docker task to build.clj which allows docker images to be built locally, and optionally published to the public swirrl artifact repository. Add deploy-docker task to the CI build to publish docker images. Update the README to include instructions on running csv2rdf via docker.
scottlowe
approved these changes
Aug 8, 2023
| @@ -124,6 +124,18 @@ jobs: | |||
| "${CIRCLE_TAG}" \ | |||
| csv2rdf-darwin.tar.gz | |||
|
|
|||
| deploy-docker: | |||
| docker: | |||
| - image: cimg/clojure:1.11.1 | |||
There was a problem hiding this comment.
I personally prefer locking the image to a known JDK version which we intend to support e.g. this snippet from the muttnik project:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #340 - Add docker task to build.clj which allows docker images to be built locally, and optionally published to the public swirrl artifact repository.
Add deploy-docker task to the CI build to publish docker images.
Update the README to include instructions on running csv2rdf via docker.