Skip to content

chore:update engine requirements #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

godky
Copy link

@godky godky commented May 29, 2025

Since this commit uses feature 'AbortController', now our engine requirements should be updated.

@SuperchupuDev
Copy link
Owner

we should probably raise an issue on fdir, since i'm pretty sure they want to remain compatible with node12. i'll merge this if they don't want to keep node12 compatibility

@godky
Copy link
Author

godky commented May 29, 2025

we should probably raise an issue on fdir, since i'm pretty sure they want to remain compatible with node12. i'll merge this if they don't want to keep node12 compatibility

oh

@Torathion
Copy link
Contributor

Torathion commented May 29, 2025

I don't think fdir still wants to support a node version from 6 years ago, even node 14 support was debated last year. I think this should be discussed in their open issue about the engines field: thecodrr/fdir#116

@SuperchupuDev
Copy link
Owner

@godky considering fdir hasn't removed their usage of AbortController and it's been two weeks (with no one reporting any issues) i might merge this. were you affected by fdir breaking node 12 support?

@godky
Copy link
Author

godky commented Jun 16, 2025

@godky considering fdir hasn't removed their usage of AbortController and it's been two weeks (with no one reporting any issues) i might merge this. were you affected by fdir breaking node 12 support?

@SuperchupuDev Yes, some of our CI environments used node12 and encountered errors, so we upgraded the node version.

@SuperchupuDev
Copy link
Owner

fyi i've posted a pinned issue talking about a possible engines update to >=16.0.0 #134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants