Add a delay before reporting transactions #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a test environment, we discovered that sometimes these jobs would be run before an order's new totals had been persisted by the `Spree::OrderUpdater`. This is an effective workaround, but it is just a workaround.
benjaminwil
force-pushed
the
delay-reporting-jobs
branch
from
bac1a83 to
06f6cb3
Compare
Noah-Silvera
approved these changes
Jan 23, 2024
forkata
approved these changes
Jan 24, 2024
|
Looks like tests should pass here after we merge #254. Thanks for adding this @benjaminwil! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
In a test environment, we discovered that sometimes these jobs would be run before an order's new totals had been persisted by the
Spree::OrderUpdater. This is an effective workaround, but it is just a workaround.Merge Checklist