Add reporting_enabled configuration option
#103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In anticipation of creating transactions in TaxJar for TaxJar's reporting functionality, we want to allow extension users to enable/disable reporting for their applications. We're defaulting setting to `false` right now as we'll be adding bits and pieces of reporting functionality over the next months. Co-Authored-By: Chris Todorov <[email protected]>
benjaminwil
force-pushed
the
benjaminwil/reporting-enabled
branch
from
3f87a8e to
fda23a5
Compare
|
Rebased against master to handle CHANGELOG conflicts. |
3 tasks
Noah-Silvera
approved these changes
Sep 1, 2021
| @@ -89,6 +92,24 @@ endpoint of the tax calculator in order to provide the most coherent and | |||
| reliable results. TaxJar support recommends using this endpoint for live | |||
| calculations. | |||
|
|
|||
| ## Configuration | |||
benjaminwil
force-pushed
the
benjaminwil/reporting-enabled
branch
from
fda23a5 to
49e9add
Compare
Since we're adding an experimental configuration option to our gem's main class, I thought we could call attention to the available configuration options in the README. This README content makes it clear how to find out what the gem's default configuration options are and the recommended way to change them.
benjaminwil
force-pushed
the
benjaminwil/reporting-enabled
branch
from
49e9add to
e48e85d
Compare
|
I updated the README in response to Noah's feedback. |
jarednorman
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #99.
What is the goal of this PR?
We want to allow end users to be able to turn the TaxJar reporting functionality of this extension on or off.
While the feature is in development, we want reporting to be disabled by default.
How do you manually test these changes? (if applicable)
Not applicable.
Merge Checklist
Screenshots
Not applicable.