STYLE: Drop the index-based "CenterOfRotation" transform parameter #1305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-Dekker
commented
Mar 17, 2025
| @@ -64,9 +61,6 @@ namespace elastix | |||
| * By default "GeometricalCenter" is assumed.\n | |||
| * | |||
| * The transform parameters necessary for transformix, additionally defined by this class, are: | |||
| * \transformparameter CenterOfRotation: stores the center of rotation as an index. \n | |||
| * example: <tt>(CenterOfRotation 128 128 90)</tt> | |||
| * deprecated! From elastix version 3.402 this is changed to CenterOfRotationPoint! | |||
There was a problem hiding this comment.
CenterOfRotation appears deprecated for AdvancedAffineTransform
N-Dekker
commented
Mar 17, 2025
| * \parameter AutomaticTransformInitialization: whether or not the initial translation | ||
| * between images should be estimated as the distance between their centers.\n | ||
| * example: <tt>(AutomaticTransformInitialization "true")</tt> \n | ||
| * By default "false" is assumed. So, no initial translation. | ||
| * | ||
| * The transform parameters necessary for transformix, additionally defined by this class, are: * | ||
| * \transformparameter CenterOfRotation: stores the center of rotation as an index. \n | ||
| * example: <tt>(CenterOfRotation 128 128 90)</tt>\n | ||
| * <b>depecrated!</b> From elastix version 3.402 this is changed to CenterOfRotationPoint! |
There was a problem hiding this comment.
CenterOfRotation appears deprecated for AffineDTITransform.
N-Dekker
commented
Mar 17, 2025
| * \parameter ComputeZYX: whether the order of rotations is ZYX. Default: "false". When false, the order is ZXY.\n | ||
| * This parameter is only relevant for 3D transformation (i.e. when the stack transform is 4D), otherwise it is | ||
| * ignored.\n | ||
| * | ||
| * The transform parameters necessary for transformix, additionally defined by this class, are: | ||
| * \transformparameter CenterOfRotation: stores the center of rotation as an index. \n | ||
| * example: <tt>(CenterOfRotation 128 128)</tt> | ||
| * deprecated! From elastix version 3.402 this is changed to CenterOfRotationPoint! |
There was a problem hiding this comment.
CenterOfRotation appears deprecated for EulerStackTransform.
N-Dekker
commented
Mar 17, 2025
| @@ -63,9 +60,6 @@ namespace elastix | |||
| * This parameter is only relevant for 3D transformation, otherwise it is ignored.\n | |||
| * | |||
| * The transform parameters necessary for transformix, additionally defined by this class, are: | |||
| * \transformparameter CenterOfRotation: stores the center of rotation as an index. \n | |||
| * example: <tt>(CenterOfRotation 128 128 90)</tt>\n | |||
| * <b>depecrated!</b> From elastix version 3.402 this is changed to CenterOfRotationPoint! | |||
There was a problem hiding this comment.
CenterOfRotation appears deprecated for EulerTransform.
N-Dekker
commented
Mar 17, 2025
| @@ -66,9 +63,6 @@ namespace elastix | |||
| * By default "GeometricalCenter" is assumed.\n | |||
| * | |||
| * The transform parameters necessary for transformix, additionally defined by this class, are: | |||
| * \transformparameter CenterOfRotation: stores the center of rotation as an index. \n | |||
| * example: <tt>(CenterOfRotation 128 128 90)</tt>\n | |||
| * <b>depecrated!</b> From elastix version 3.402 this is changed to CenterOfRotationPoint! | |||
There was a problem hiding this comment.
CenterOfRotation appears deprecated for SimilarityTransform.
|
Discussed with Stefan (@stefanklein) at our bi-weekly internal elastix sprint. We concluded that the index-based "CenterOfRotation" parameter may be dropped for TransformParameter files, but not for registration parameter files. For registration parameter files, it may still be useful to specify the center of rotation by its grid index. |
N-Dekker
force-pushed
the
Drop-CenterOfRotation
branch
from
3d00dc8 to
98dc30f
Compare
elastix version 3.402 deprecated the index-based "CenterOfRotation" in favor of "CenterOfRotationPoint" (which assumes world coordinates). Following: - commit 70dd3b8, "ENH: added the possibility to set the CenterOfRotationPoint", Marius Staring, Aug 2, 2006. - pull request #190 commit 47c470f, "BUG: No longer read rotation center as index (elastix transform < 3.402)", 24 Sep 2019
N-Dekker
force-pushed
the
Drop-CenterOfRotation
branch
from
98dc30f to
2235eaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
elastix version 3.402 deprecated the index-based "CenterOfRotation" in favor of "CenterOfRotationPoint" (which assumes world coordinates).
Following:
commit 70dd3b8, "ENH: added the possibility to set the CenterOfRotationPoint", Marius Staring, Aug 2, 2006.
pull request BUG: No longer read rotation center as index (elastix transform < 3.402) #190 commit 47c470f, "BUG: No longer read rotation center as index (elastix transform < 3.402)", 24 Sep 2019
@mstaring @stefanklein Please check, is this OK to you both? (Entirely dropping the index-based CenterOfRotation.)