Skip to content

Player(Shell): add audio boost control #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 18, 2025

Conversation

ivelinmegdanov
Copy link
Contributor

@ivelinmegdanov ivelinmegdanov commented Feb 3, 2025

This PR enhances the volume control system by introducing dynamic volume limits, improved UI feedback, and shell-based volume boosting. The following improvements have been implemented:

  • Volume Boosting Logic:

    • Max volume is now 200 only when shell.active is true.
    • Default max volume remains 100 when shell.active is false.
  • Improved UI for Volume Slider:

    • Added gradient feedback for warning and danger levels:
      • White (0-100%) → Yellow (150%) → Red (200%)
  • Keyboard & Scroll Volume Control Fixes:

    • ArrowUp & ArrowDown keys now correctly adjust volume within valid ranges.
    • Mouse Scroll (onWheel) correctly respects volume limits and prevents overflows.
      • mouse scroll (onWheel) volume control is limited to 100%
      • To increase volume beyond 100% (up to 200%), the user must manually adjust the slider or use keyboard controls
    • Note: In the previous version, inside the Stremio shell, users were able to infinitely increase the volume using the ArrowUp and onWheel controls. There was no upper limit, allowing volume to exceed reasonable levels.

Note: This feature is designed only for the shell because browsers impose a hard limit on volume at 100%.

Closes Issue #322
Closes https://github.com/Stremio/stremio-tasks/issues/319

@CLAassistant
Copy link

CLAassistant commented Feb 3, 2025

CLA assistant check
All committers have signed the CLA.

@ivelinmegdanov ivelinmegdanov self-assigned this Feb 3, 2025
@ivelinmegdanov ivelinmegdanov added bug Something isn't working feature New feature implementation labels Feb 3, 2025
@kKaskak kKaskak added this to the v.5.0.0-beta.18 milestone Feb 3, 2025
@tymmesyde tymmesyde changed the title Enhance Volume Control: Dynamic Limits, UI Improvements, and Shell-Based Boosting Player(shell): add audio boost Feb 18, 2025
@tymmesyde tymmesyde merged commit dfe509d into development Feb 18, 2025
2 checks passed
@tymmesyde tymmesyde changed the title Player(shell): add audio boost Player(Shell): add audio boost control Feb 18, 2025
@elpiel elpiel deleted the feat/shell-volume-booster branch February 18, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature New feature implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants