Skip to content

refactor: AssembledTransaction.simulate and AssembledTransactionAsync.simulate will no longer restore the state for read-only transactions. #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

overcat
Copy link
Member

@overcat overcat commented Mar 4, 2025

No description provided.

…ync.simulate` will no longer restore the state for read-only transactions.
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.27%. Comparing base (b5b6698) to head (6d78e01).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1026   +/-   ##
=======================================
  Coverage   98.27%   98.27%           
=======================================
  Files         262      262           
  Lines       14228    14228           
=======================================
  Hits        13982    13982           
  Misses        246      246           
Flag Coverage Δ
unittests 98.27% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
stellar_sdk/contract/assembled_transaction.py 80.34% <100.00%> (ø)
...tellar_sdk/contract/assembled_transaction_async.py 79.42% <100.00%> (ø)

@overcat overcat enabled auto-merge (squash) March 4, 2025 02:45
@overcat overcat merged commit 5b33d38 into main Mar 4, 2025
53 checks passed
@overcat overcat deleted the dont-restore-read-call branch April 11, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant