validate layer config zoom values are within min/max bounds #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jerluc I can't assign reviewers on forked pull requests, so I'm linking you in this way :) |
jerluc
reviewed
Nov 12, 2020
There was a problem hiding this comment.
@brian-dellabetta, these changes look generally good to me, but I'll hold off on merge until you can get your suggested change to implement a simple validator interface working for LayerConfig.
|
Conflicts have been separately resolved in the updated PR #49 and merged down. Thanks again for your contributions @brian-dellabetta! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #24
As discussed, layer configurations with minzoom values below the
MinZoomserver configuration or maxzoom values above theMaxZoomserver configuration will trigger a panic at startup.I added a couple tests and updated the comments describing
MinZoom/MaxZoomto add some more clarity, based on conversation thread referenced above.