Skip to content

fix: add check for empty response #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2020
Merged

fix: add check for empty response #34

merged 1 commit into from
Nov 6, 2020

Conversation

saffaalvi
Copy link
Contributor

@saffaalvi saffaalvi commented Oct 27, 2020 •
edited
Loading

Resolves #33

  • Checks to see if response from API is not empty
  • Fix cost table message to be more descriptive (over the last 24 hours instead of per day) as it is confusing to some users

@saffaalvi saffaalvi requested a review from brendangadd October 27, 2020 22:35
@wg102 wg102 mentioned this pull request Oct 29, 2020
Merged
brendangadd
brendangadd suggested changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@brendangadd brendangadd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes need formatting. @wg102 can show you how to make Prettier only format the parts you've changed when you save in VS Code, which will avoid adding ~20 files worth of formatting to this PR. :)

brendangadd
brendangadd previously approved these changes Nov 6, 2020
View reviewed changes
@brendangadd brendangadd dismissed their stale review November 6, 2020 16:41

Conflicts

@saffaalvi saffaalvi force-pushed the fix-kubecost-error branch 4 times, most recently from 3b44dd6 to 5eeb93f Compare November 6, 2020 18:25
@brendangadd brendangadd merged commit d412a39 into master Nov 6, 2020
@brendangadd brendangadd deleted the fix-kubecost-error branch November 6, 2020 18:46
saffaalvi pushed a commit that referenced this pull request Feb 11, 2021
@brendangadd
Merge pull request #34 from StatCan/fix-kubecost-error
339fc11 
fix: add check for empty response
@wg102 wg102 mentioned this pull request Sep 12, 2022
Closed
15 tasks
@mathis-marcotte mathis-marcotte mentioned this pull request Sep 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ca-scribner ca-scribner ca-scribner left review comments

@brendangadd brendangadd brendangadd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix error message when running locally
3 participants
@saffaalvi @brendangadd @ca-scribner