Kf1.7 jupyter backend #228
Conversation
| Container: notebook, | ||
| } | ||
| podLogsRequest := s.clientsets.kubernetes.CoreV1().Pods(namespace).GetLogs(pod, &podLogsOpts) | ||
| podLogs, err := podLogsRequest.Stream(context.TODO()) |
There was a problem hiding this comment.
I'm assuming .Stream allows the logs to be streamed from the k8s api server? Can we get a comment on the usage of .TODO() since the docs say to be used when the context to use is unclear or not available.
There was a problem hiding this comment.
Ill be honest that this is pretty much just copy pasted from an online answer. But yes .Stream looks like that is what it is doing, and the context.TODO is because it is unclear(i assume).
thunder-tests/thunderclient.json
Outdated
There was a problem hiding this comment.
Is this pre-config for test cases? They don't show up on my pc so I'm wondering if I did something wrong.
There was a problem hiding this comment.
This is the json definition for all the test cases. They should appear in the thunder client extension in vscode, under the "collections" tab.
There was a problem hiding this comment.
One thing that might be useful is possibly linking each upstream fn in-line above the translated fn. I think it would help lots in trace-ability. It's sorta tedious to hop around the different files looking for the upstream code :(
I could do it later I wouldn't say it's priority.
There was a problem hiding this comment.
So basically taking the links that we have in the table in the readme and putting them directly above the functions in the code? I would agree that it could help us when comparing with upstream
* Update common folder (#227) * Code update Common Folder * added notebook page (#233) Co-authored-by: Mathis Marcotte <[email protected]> * added volume-details-page (#234) Co-authored-by: Mathis Marcotte <[email protected]> * Kf1.7 jupyter apis index frontend (#235) * updated jupyter index files --------- Co-authored-by: Mathis Marcotte <[email protected]> * Update jupyter general (#239) General code in all folders * Kf1.7 jupyter form update (#236) * renamed form-default to form-new * updated form for 1.7 --------- Co-authored-by: Mathis Marcotte <[email protected]> * Kf1.7 jupyter backend (#228) * updated get pvcs request * updated poddefaults return response * added new jupyter endpoints * updated access review spec * added new volume endpoints * updated readme for thunder client --------- Co-authored-by: Mathis Marcotte <[email protected]> * Kf1.7 volume table stuff (#241) * imported volume components --------- Co-authored-by: Mathis Marcotte <[email protected]> * fixes to be able to run jupyter-apis (#242) * fixes to be able to run jupyter-apis * index related fixes * revert change in namespace * fixed some form issues * fixed some issues with the details page * fixed monaco-editor for loading * hid volumes form * fixed the custom image checkbox hiding images * fixed some bugs with the form-image * revert the form images * fixed some more issues * updated go package --------- Co-authored-by: Mathis Marcotte <[email protected]> * fixed vulnerabilities (#246) Co-authored-by: Mathis Marcotte <[email protected]> * deleted useless packa-lock file * reverted change to build-angular package version * Kf1.7 vulnerabilities (#247) * fixed vulnerabilities for common * fixed vulnerabilities for jupyter frontend --------- Co-authored-by: Mathis Marcotte <[email protected]> * Kf1.7 frontend js tests (#248) * fixes to be able to run jupyter-apis * index related fixes * revert change in namespace * fixed some form issues * fixed some issues with the details page * fixed monaco-editor for loading * hid volumes form * fixed the custom image checkbox hiding images * fixed some bugs with the form-image * revert the form images * fixed some more issues * updated go package * fixed some of the issues with the js tests --------- Co-authored-by: Mathis Marcotte <[email protected]> * fixed bug with declarations * set docker image to node 16 * Kf1.7 cypress (#249) * kf1.7 cypress update * fixed cypress tests --------- Co-authored-by: Mathis Marcotte <[email protected]> * fixed semver vulnerability issue * kf1.7 added new workflows (#250) * added new workflows * testing with different triggers * ran prettier to format * fixed lint picking up node_modules * deleted workflow that got replaced * ran prettier on jupyter * initial lint fix for jupyter * write prettier on jupyter * jupyter lint * more formatting and linting * fixed issues * formatting --------- Co-authored-by: Mathis Marcotte <[email protected]> * removed old tslint file * updated golang version * updated go version * updated readme --------- Co-authored-by: Wendy Gaultier <[email protected]> Co-authored-by: Mathis Marcotte <[email protected]>
issue #225
for updating our backend to match KF1.7
In the linked issue are the listed api endpoints that needed to be updated or added.
My main concern was where the newly added functions should get added. Since the source of the info returned are from notebooks/pvcs, I put the functions under
notebooks.goandpersistentvolumeclaims.go.But would it be better to organise those by the data that is being returned? So maybe create something like a
pods.goandevents.gosince that is the data that is being returned.