Skip to content

Jupyter Web Apps: Build + Push to ACR on PR #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Collinbrown95 opened this issue Oct 12, 2022 · 2 comments · Fixed by StatCan/jupyter-apis#201 or StatCan/kubeflow#134
Closed

Jupyter Web Apps: Build + Push to ACR on PR #1382

Collinbrown95 opened this issue Oct 12, 2022 · 2 comments · Fixed by StatCan/jupyter-apis#201 or StatCan/kubeflow#134
Assignees
Labels
kind/feature New feature or request

Comments

@Collinbrown95
Copy link
Contributor

Description

Instead of pushing commits to main to test the image, can we run the build.yml and publish.yml workflows on pull request events? I think this should be possible with something like https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request

CC @Souheil-Yazji

@Collinbrown95 Collinbrown95 added the kind/feature New feature or request label Oct 12, 2022
Collinbrown95 added a commit to StatCan/jupyter-apis that referenced this issue Oct 12, 2022
temporary workaround until decision is reached on
StatCan/aaw#1382
@Jose-Matsuda
Copy link
Contributor

Jose-Matsuda commented Feb 8, 2023

If this is just for jupyter-apis I think we have something in place for that (now, not at time of original writing) as seen here (issue)

Having said that, the change here (that triggers on prs with the auto-deploy tag pushes to the regular acr and not the dev acr. This is more for the cleaning task of the acrs where say for the dev one we do a full clean and for the regular acr we keep a history of the last 5 images.

@mathis-marcotte
Copy link
Contributor

After discussing it, we will just update the auto-deploy tag to have it push to the dev ACR instead of the regular ACR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
3 participants