Skip to content

Upgrade 1.7 Common Component: oidc-authservice #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wg102 opened this issue Jun 27, 2023 · 0 comments · Fixed by #348
Closed

Upgrade 1.7 Common Component: oidc-authservice #347

wg102 opened this issue Jun 27, 2023 · 0 comments · Fixed by #348
Assignees

Comments

@wg102
Copy link
Contributor

wg102 commented Jun 27, 2023

Adjustments

  • New Rbac file in base
  • New env var in params.env
  • New service account name in statefulset

I did not add the rbac since it should be imported. Same with the env var
I did add the new service account name to statefulset since we override that file.

Testing

Usually a good idea to make sure all of the overrides are working is to run the following command and verify all the yaml output for the component is what you expect and all of the overrides are taken into account.

  • The kubeflow-namespace Namespace is patched correctly (removed label)
task stack:aaw:preview

Note: The command above will render all of the manifests into manifests top level folder with the name aaw.yaml. A trick to keep the yaml output small is under stacks/aaw/kustomization.yaml to only have the component you wish to test referenced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant