Skip to content

[BugFix] frame_start/frame_end is modified unexpectedly when the window contains lead/lag and other agg #58437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2025
Merged

[BugFix] frame_start/frame_end is modified unexpectedly when the window contains lead/lag and other agg #58437

merged 1 commit into from
Apr 27, 2025

Conversation

satanson
Copy link
Contributor

@satanson satanson commented Apr 27, 2025 •
edited
Loading

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.5
    • 3.4
    • 3.3
    • 3.2
    • 3.1

@satanson satanson requested a review from a team as a code owner April 27, 2025 03:11
@satanson
[BugFix] frame_start/frame_end is modified unexpectedly when the wind…
566c8b2 
…ow contains lead/lag and other agg

Signed-off-by: satanson <[email protected]>
@satanson satanson force-pushed the frame_start_end_modified branch from 83447e1 to 566c8b2 Compare April 27, 2025 05:36
@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 5 / 5 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exec/analytor.cpp 5 5 100.00% []

@Seaven Seaven merged commit 7f90165 into main Apr 27, 2025
89 checks passed
@Seaven Seaven deleted the frame_start_end_modified branch April 27, 2025 11:01
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.4

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.5

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Apr 27, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 27, 2025 •
edited
Loading

backport branch-3.4

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 27, 2025 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 27, 2025 •
edited
Loading

backport branch-3.5

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 27, 2025 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 27, 2025 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 27, 2025
@satanson @mergify
[BugFix] frame_start/frame_end is modified unexpectedly when the wind…
931ae1d 
…ow contains lead/lag and other agg (#58437)

Signed-off-by: satanson <[email protected]>
(cherry picked from commit 7f90165)
@mergify mergify bot mentioned this pull request Apr 27, 2025
Merged
24 tasks
mergify bot pushed a commit that referenced this pull request Apr 27, 2025
@satanson @mergify
[BugFix] frame_start/frame_end is modified unexpectedly when the wind…
c284a23 
…ow contains lead/lag and other agg (#58437)

Signed-off-by: satanson <[email protected]>
(cherry picked from commit 7f90165)

# Conflicts:
#	be/src/exec/analytor.cpp
@mergify mergify bot mentioned this pull request Apr 27, 2025
Closed
24 tasks
mergify bot pushed a commit that referenced this pull request Apr 27, 2025
@satanson @mergify
[BugFix] frame_start/frame_end is modified unexpectedly when the wind…
901d480 
…ow contains lead/lag and other agg (#58437)

Signed-off-by: satanson <[email protected]>
(cherry picked from commit 7f90165)
@mergify mergify bot mentioned this pull request Apr 27, 2025
Merged
24 tasks
mergify bot pushed a commit that referenced this pull request Apr 27, 2025
@satanson @mergify
[BugFix] frame_start/frame_end is modified unexpectedly when the wind…
878b558 
…ow contains lead/lag and other agg (#58437)

Signed-off-by: satanson <[email protected]>
(cherry picked from commit 7f90165)

# Conflicts:
#	be/src/exec/analytor.cpp
mergify bot pushed a commit that referenced this pull request Apr 27, 2025
@satanson @mergify
[BugFix] frame_start/frame_end is modified unexpectedly when the wind…
67a0dee 
…ow contains lead/lag and other agg (#58437)

Signed-off-by: satanson <[email protected]>
(cherry picked from commit 7f90165)

# Conflicts:
#	be/src/exec/analytor.cpp
This was referenced Apr 27, 2025
Closed
Closed
satanson added a commit that referenced this pull request Apr 27, 2025
@satanson
[BugFix] frame_start/frame_end is modified unexpectedly when the wind…
fb1c562 
…ow contains lead/lag and other agg(backport #58437)

Signed-off-by: satanson <[email protected]>
@satanson satanson mentioned this pull request Apr 27, 2025
Merged
24 tasks
satanson added a commit that referenced this pull request Apr 27, 2025
@satanson
[BugFix] frame_start/frame_end is modified unexpectedly when the wind…
3d51030 
…ow contains lead/lag and other agg(backport #58437)

Signed-off-by: satanson <[email protected]>
@satanson satanson mentioned this pull request Apr 27, 2025
Merged
24 tasks
satanson added a commit that referenced this pull request Apr 27, 2025
@satanson
[BugFix] frame_start/frame_end is modified unexpectedly when the wind…
0666e5b 
…ow contains lead/lag and other agg(backport #58437)

Signed-off-by: satanson <[email protected]>
@satanson satanson mentioned this pull request Apr 27, 2025
Merged
24 tasks
wanpengfei-git pushed a commit that referenced this pull request Apr 27, 2025
@mergify @satanson
[BugFix] frame_start/frame_end is modified unexpectedly when the wind…
a51f0fc 
…ow contains lead/lag and other agg (backport #58437) (#58460)

Signed-off-by: satanson <[email protected]>
Co-authored-by: satanson <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Apr 27, 2025
@mergify @satanson
[BugFix] frame_start/frame_end is modified unexpectedly when the wind…
a6ab143 
…ow contains lead/lag and other agg (backport #58437) (#58462)

Signed-off-by: satanson <[email protected]>
Co-authored-by: satanson <[email protected]>
kangkaisen pushed a commit that referenced this pull request Apr 28, 2025
@satanson
[BugFix] frame_start/frame_end is modified unexpectedly when the wind…
2d7e9b8 
…ow contains lead/lag and other agg(backport #58437) (#58467)

Signed-off-by: satanson <[email protected]>
kangkaisen pushed a commit that referenced this pull request Apr 28, 2025
@satanson
[BugFix] frame_start/frame_end is modified unexpectedly when the wind…
ce48f95 
…ow contains lead/lag and other agg(backport #58437) (#58465)

Signed-off-by: satanson <[email protected]>
kangkaisen pushed a commit that referenced this pull request Apr 28, 2025
@satanson
[BugFix] frame_start/frame_end is modified unexpectedly when the wind…
eec8224 
…ow contains lead/lag and other agg(backport #58437) (#58466)

Signed-off-by: satanson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seaven Seaven Seaven approved these changes

@trueeyu trueeyu trueeyu approved these changes

@ZiheLiu ZiheLiu ZiheLiu approved these changes

@before-Sunrise before-Sunrise before-Sunrise approved these changes

Assignees

@satanson satanson

Labels
3.1-merged 3.2-merged 3.3-merged 3.4-merged 3.5-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@satanson @Seaven @trueeyu @ZiheLiu @before-Sunrise