Skip to content

[Enhancement] support show multi column stats meta #57953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

stephen-shelby
Copy link
Contributor

@stephen-shelby stephen-shelby commented Apr 12, 2025

Why I'm doing:

What I'm doing:

mysql> show multiple columns stats meta\G
*************************** 1. row ***************************
Database: my_test
Table: t5
Columns: [k1, k2]
Type: SAMPLE
StatisticsTypes: MCDISTINCT
UpdateTime: 2025-04-13 00:01:02
Properties: {is_multi_column_stats=true}

other changes:

  1. add multi-columns stats job flag to analyze job
  2. modify StatisticsType to List<StatsConstants.StatisticsType> for MultiColumnStatsMeta
  3. fix multi-columns meta replay bug

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.5
    • 3.4
    • 3.3
    • 3.2
    • 3.1

@stephen-shelby stephen-shelby requested review from a team as code owners April 12, 2025 15:52
@wanpengfei-git wanpengfei-git requested a review from a team April 12, 2025 15:52
@github-actions github-actions bot added the 3.5 label Apr 12, 2025
@stephen-shelby stephen-shelby force-pushed the add_multi_column_flag branch 2 times, most recently from 95c0eb8 to 2e7cf82 Compare April 14, 2025 03:31
@stephen-shelby stephen-shelby requested a review from a team as a code owner April 14, 2025 03:31
@stephen-shelby stephen-shelby force-pushed the add_multi_column_flag branch from 2e7cf82 to 0c31ee9 Compare April 14, 2025 03:36
@stephen-shelby stephen-shelby requested a review from a team as a code owner April 14, 2025 03:36
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
7.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

fail : 67 / 85 (78.82%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/qe/StmtExecutor.java 1 3 33.33% [1520, 1679]
🔵 com/starrocks/statistic/StatisticsMetaManager.java 2 6 33.33% [335, 336, 337, 338]
🔵 com/starrocks/statistic/AnalyzeMgr.java 5 11 45.45% [298, 302, 303, 887, 1091, 1101]
🔵 com/starrocks/sql/ast/ShowMultiColumnStatsMetaStmt.java 34 39 87.18% [67, 72, 77, 78, 98]
🔵 com/starrocks/qe/ShowExecutor.java 13 14 92.86% [2556]
🔵 com/starrocks/sql/analyzer/ShowStmtAnalyzer.java 2 2 100.00% []
🔵 com/starrocks/sql/ast/AstVisitor.java 1 1 100.00% []
🔵 com/starrocks/persist/EditLogDeserializer.java 2 2 100.00% []
🔵 com/starrocks/statistic/StatisticExecutor.java 5 5 100.00% []
🔵 com/starrocks/statistic/MultiColumnStatsMeta.java 2 2 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@HangyuanLiu HangyuanLiu self-assigned this Apr 14, 2025
@andyziye andyziye merged commit 619fd73 into StarRocks:main Apr 14, 2025
80 of 83 checks passed
Copy link

@Mergifyio backport branch-3.5

@github-actions github-actions bot removed the 3.5 label Apr 14, 2025
Copy link
Contributor

mergify bot commented Apr 14, 2025

backport branch-3.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 14, 2025
Signed-off-by: stephen <[email protected]>
(cherry picked from commit 619fd73)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/qe/ShowExecutor.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants