Skip to content

[BugFix] Fix some cost predicate bugs #57929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

LiShuMing
Copy link
Contributor

@LiShuMing LiShuMing commented Apr 11, 2025

Why I'm doing:

  • Support non-OlapTables for cost predicator;
  • Ensure only to useCostPredictor when it's available .

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.5
    • 3.4
    • 3.3
    • 3.2
    • 3.1

@LiShuMing LiShuMing requested a review from a team as a code owner April 11, 2025 09:14
@github-actions github-actions bot added the 3.5 label Apr 11, 2025
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

fail : 8 / 12 (66.67%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/qe/StmtExecutor.java 0 1 00.00% [1335]
🔵 com/starrocks/sql/optimizer/cost/feature/PlanFeatures.java 2 5 40.00% [217, 218, 220]
🔵 com/starrocks/sql/optimizer/cost/feature/CostPredictor.java 6 6 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@kangkaisen kangkaisen merged commit 8f3265c into StarRocks:main Apr 14, 2025
65 of 73 checks passed
Copy link

@Mergifyio backport branch-3.5

@github-actions github-actions bot removed the 3.5 label Apr 14, 2025
Copy link
Contributor

mergify bot commented Apr 14, 2025

backport branch-3.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 14, 2025
Signed-off-by: shuming.li <[email protected]>
(cherry picked from commit 8f3265c)
wanpengfei-git pushed a commit that referenced this pull request Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants