-
Notifications
You must be signed in to change notification settings - Fork 2k
[BugFix] concat(col) should return cloned column instead of original column to avoid abusing sharing column #57522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…column to avoid abusing sharing column Signed-off-by: satanson <[email protected]>
before-Sunrise
approved these changes
Apr 2, 2025
ZiheLiu
approved these changes
Apr 2, 2025
LiShuMing
approved these changes
Apr 2, 2025
Seaven
approved these changes
Apr 2, 2025
satanson
added a commit
that referenced
this pull request
Apr 2, 2025
…column to avoid abusing sharing column (backport #57522) Signed-off-by: satanson <[email protected]>
24 tasks
satanson
added a commit
that referenced
this pull request
Apr 2, 2025
…column to avoid abusing sharing column (backport #57522) Signed-off-by: satanson <[email protected]>
24 tasks
kangkaisen
pushed a commit
that referenced
this pull request
Apr 2, 2025
…column to avoid abusing sharing column (backport #57522) (#57523) Signed-off-by: satanson <[email protected]>
andyziye
pushed a commit
that referenced
this pull request
Apr 2, 2025
…column to avoid abusing sharing column (backport #57522) (#57524) Signed-off-by: satanson <[email protected]>
@Mergifyio backport branch-3.1 |
@Mergifyio backport branch-3.5 |
@Mergifyio backport branch-3.3 |
@Mergifyio backport branch-3.4 |
@Mergifyio backport branch-3.2 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
…column to avoid abusing sharing column (#57522) Signed-off-by: satanson <[email protected]> (cherry picked from commit 0380dcd)
18 tasks
mergify bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
…column to avoid abusing sharing column (#57522) Signed-off-by: satanson <[email protected]> (cherry picked from commit 0380dcd)
24 tasks
mergify bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
…column to avoid abusing sharing column (#57522) Signed-off-by: satanson <[email protected]> (cherry picked from commit 0380dcd)
24 tasks
mergify bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
…column to avoid abusing sharing column (#57522) Signed-off-by: satanson <[email protected]> (cherry picked from commit 0380dcd)
24 tasks
mergify bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
…column to avoid abusing sharing column (#57522) Signed-off-by: satanson <[email protected]> (cherry picked from commit 0380dcd)
24 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Apr 2, 2025
…column to avoid abusing sharing column (backport #57522) (#57529) Co-authored-by: satanson <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Apr 2, 2025
…column to avoid abusing sharing column (backport #57522) (#57530) Co-authored-by: satanson <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Apr 2, 2025
…column to avoid abusing sharing column (backport #57522) (#57528) Co-authored-by: satanson <[email protected]>
satanson
added a commit
that referenced
this pull request
Apr 2, 2025
…column to avoid abusing sharing column (#57522) Signed-off-by: satanson <[email protected]> (cherry picked from commit 0380dcd) Signed-off-by: satanson <[email protected]>
andyziye
pushed a commit
that referenced
this pull request
Apr 2, 2025
…column to avoid abusing sharing column (backport #57522) (#57526) Co-authored-by: satanson <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Apr 2, 2025
…column to avoid abusing sharing column (backport #57522) (#57527) Signed-off-by: satanson <[email protected]> Co-authored-by: satanson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Chunk::check_or_die fails since columns in chunk has different sizes.
The root cause is:
In the plan, project operator output both column dept_nbr and concat(dept_nbr), when concat is applied to only one argument, the column is return directly, so dept_nbr appears twice in output chunk of project operator, accumulator operator is descendant of the project operator, it try to merge small chunks into big one via column::append method, so twice-appearing column is appended twice, its size is large than other columns.
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: