Skip to content

[Enhancement] use histogram to evaluate list partition #57147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2025

Conversation

stephen-shelby
Copy link
Contributor

@stephen-shelby stephen-shelby commented Mar 21, 2025

Why I'm doing:

What I'm doing:

currently, we use partition level statistics without histogram to estimate node output rows and histogram is table level. However, based on the premise that partition is independent, we could use histogram or mcv to estimate cardinality.

added session variable:
cbo_use_histogram_evaluate_list_partition.
default value is false.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@stephen-shelby stephen-shelby requested a review from a team as a code owner March 21, 2025 06:24
@stephen-shelby stephen-shelby force-pushed the eval_list_with_histo branch 2 times, most recently from 9b43ea9 to 06cf5ed Compare March 24, 2025 02:26
@stephen-shelby stephen-shelby changed the title [Enhancement] use histogram to evaluate list partition [UT] use histogram to evaluate list partition Mar 24, 2025
@stephen-shelby stephen-shelby changed the title [UT] use histogram to evaluate list partition [Enhancement] use histogram to evaluate list partition Mar 24, 2025
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@stephen-shelby stephen-shelby requested a review from Seaven March 24, 2025 11:29
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 28 / 34 (82.35%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/statistics/StatisticStorage.java 0 1 00.00% [45]
🔵 com/starrocks/qe/SessionVariable.java 2 4 50.00% [1771, 1772]
🔵 com/starrocks/sql/optimizer/statistics/CachedStatisticStorage.java 18 21 85.71% [187, 189, 190]
🔵 com/starrocks/sql/optimizer/statistics/StatisticsCalcUtils.java 6 6 100.00% []
🔵 com/starrocks/statistic/AnalyzeMgr.java 1 1 100.00% []
🔵 com/starrocks/sql/optimizer/statistics/StatisticsCalculator.java 1 1 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@stephen-shelby stephen-shelby merged commit 83088c8 into StarRocks:main Mar 24, 2025
54 of 55 checks passed
Copy link

@Mergifyio backport branch-3.4

Copy link

@Mergifyio backport branch-3.3

Copy link
Contributor

mergify bot commented Mar 24, 2025

backport branch-3.4

✅ Backports have been created

Copy link
Contributor

mergify bot commented Mar 24, 2025

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 24, 2025
Signed-off-by: stephen <[email protected]>
(cherry picked from commit 83088c8)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/qe/SessionVariable.java
mergify bot pushed a commit that referenced this pull request Mar 24, 2025
Signed-off-by: stephen <[email protected]>
(cherry picked from commit 83088c8)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/qe/SessionVariable.java
#	test/sql/test_list_partition/R/test_list_partition_cardinality
wanpengfei-git pushed a commit that referenced this pull request Mar 24, 2025
wanpengfei-git pushed a commit that referenced this pull request Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants