Skip to content

[BugFix] Fix insert into files statement not support delimiter convert #57126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 24, 2025
Merged

[BugFix] Fix insert into files statement not support delimiter convert #57126

merged 2 commits into from
Mar 24, 2025

Conversation

wxl24life
Copy link
Contributor

Why I'm doing:

What I'm doing:

Fixes #57125

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@wxl24life wxl24life requested a review from a team as a code owner March 20, 2025 15:14
@github-actions github-actions bot added the 3.4 label Mar 20, 2025
@github-actions github-actions bot added the 3.3 label Mar 20, 2025
@wxl24life wxl24life force-pushed the xiaolong/github-fix-csv-delimiter-for-insert-into-files branch from daf2ae4 to 900df29 Compare March 20, 2025 15:26
@wxl24life wxl24life force-pushed the xiaolong/github-fix-csv-delimiter-for-insert-into-files branch from ca83cf3 to 23bd34a Compare March 21, 2025 01:29
@wxl24life wxl24life force-pushed the xiaolong/github-fix-csv-delimiter-for-insert-into-files branch from 5cf72ad to 5f15892 Compare March 21, 2025 06:10
@wxl24life wxl24life force-pushed the xiaolong/github-fix-csv-delimiter-for-insert-into-files branch from 5f15892 to 209d82e Compare March 21, 2025 11:02
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 10 / 10 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/catalog/TableFunctionTable.java 10 10 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@HangyuanLiu HangyuanLiu self-assigned this Mar 24, 2025
@caneGuy caneGuy merged commit 335862d into StarRocks:main Mar 24, 2025
53 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Mar 24, 2025
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Mar 24, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 24, 2025 •
edited
Loading

backport branch-3.4

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 24, 2025 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 24, 2025
@wxl24life @mergify
[BugFix] Fix insert into files statement not support delimiter conv…
95f11d3 
…ert (#57126)

Signed-off-by: drake_wang <[email protected]>
(cherry picked from commit 335862d)
@mergify mergify bot mentioned this pull request Mar 24, 2025
Merged
18 tasks
mergify bot pushed a commit that referenced this pull request Mar 24, 2025
@wxl24life @mergify
[BugFix] Fix insert into files statement not support delimiter conv…
eac4b31 
…ert (#57126)

Signed-off-by: drake_wang <[email protected]>
(cherry picked from commit 335862d)
@mergify mergify bot mentioned this pull request Mar 24, 2025
Merged
18 tasks
@wxl24life wxl24life deleted the xiaolong/github-fix-csv-delimiter-for-insert-into-files branch March 24, 2025 06:50
wanpengfei-git pushed a commit that referenced this pull request Mar 25, 2025
@mergify @wxl24life
[BugFix] Fix insert into files statement not support delimiter conv…
ed25531 
…ert (backport #57126) (#57223)

Co-authored-by: Drake Wang <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Mar 25, 2025
@mergify @wxl24life
[BugFix] Fix insert into files statement not support delimiter conv…
83035be 
…ert (backport #57126) (#57224)

Co-authored-by: Drake Wang <[email protected]>
@wangsimo0
Copy link
Contributor

ignore backport check: 3.3.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevincai kevincai kevincai approved these changes

@HangyuanLiu HangyuanLiu HangyuanLiu approved these changes

Assignees

@wxl24life wxl24life

@HangyuanLiu HangyuanLiu

Labels
3.3-merged 3.4-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

INSERT INTO FILES fail to parse row/column delimiter like '0x11'
5 participants
@wxl24life @wangsimo0 @kevincai @HangyuanLiu @caneGuy