Skip to content

[Enhancement] add metrics for statistics collect jobs #56693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2025

Conversation

silverbullet233
Copy link
Contributor

@silverbullet233 silverbullet233 commented Mar 7, 2025

Why I'm doing:

What I'm doing:

Add some counter metrics to observe the status of the statistics collection job.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@silverbullet233 silverbullet233 requested review from a team as code owners March 7, 2025 04:20
Signed-off-by: silverbullet233 <[email protected]>
@silverbullet233 silverbullet233 force-pushed the add_stats_job_metrics branch from fa3948a to f5a53bc Compare March 7, 2025 09:48
Copy link

sonarqubecloud bot commented Mar 7, 2025

Copy link

github-actions bot commented Mar 7, 2025

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Mar 7, 2025

[FE Incremental Coverage Report]

pass : 17 / 19 (89.47%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/statistic/SampleStatisticsCollectJob.java 0 1 00.00% [92]
🔵 com/starrocks/statistic/FullStatisticsCollectJob.java 0 1 00.00% [409]
🔵 com/starrocks/statistic/HyperStatisticsCollectJob.java 1 1 100.00% []
🔵 com/starrocks/statistic/ExternalFullStatisticsCollectJob.java 1 1 100.00% []
🔵 com/starrocks/metric/MetricRepo.java 6 6 100.00% []
🔵 com/starrocks/statistic/ExternalSampleStatisticsCollectJob.java 1 1 100.00% []
🔵 com/starrocks/statistic/ExternalHistogramStatisticsCollectJob.java 1 1 100.00% []
🔵 com/starrocks/statistic/StatisticExecutor.java 6 6 100.00% []
🔵 com/starrocks/statistic/HistogramStatisticsCollectJob.java 1 1 100.00% []

Copy link

github-actions bot commented Mar 7, 2025

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@github-actions github-actions bot added the 3.4 label Mar 10, 2025
@silverbullet233 silverbullet233 enabled auto-merge (squash) March 10, 2025 02:06
@silverbullet233 silverbullet233 merged commit 9606072 into StarRocks:main Mar 10, 2025
67 checks passed
@silverbullet233 silverbullet233 deleted the add_stats_job_metrics branch March 10, 2025 02:07
Copy link

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Mar 10, 2025
Copy link
Contributor

mergify bot commented Mar 10, 2025

backport branch-3.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 10, 2025
Signed-off-by: silverbullet233 <[email protected]>
(cherry picked from commit 9606072)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/statistic/HyperStatisticsCollectJob.java
#	fe/fe-core/src/main/java/com/starrocks/statistic/StatisticExecutor.java
#	fe/fe-core/src/main/java/com/starrocks/statistic/StatisticsCollectJob.java
@silverbullet233
Copy link
Contributor Author

@mergify backport branch-3.3

Copy link
Contributor

mergify bot commented Mar 11, 2025

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 11, 2025
Signed-off-by: silverbullet233 <[email protected]>
(cherry picked from commit 9606072)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/statistic/ExternalSampleStatisticsCollectJob.java
#	fe/fe-core/src/main/java/com/starrocks/statistic/HyperStatisticsCollectJob.java
#	fe/fe-core/src/main/java/com/starrocks/statistic/StatisticExecutor.java
#	fe/fe-core/src/main/java/com/starrocks/statistic/StatisticsCollectJob.java
silverbullet233 added a commit that referenced this pull request Mar 11, 2025
… (#56798)

Signed-off-by: silverbullet233 <[email protected]>
Co-authored-by: eyes_on_me <[email protected]>
Co-authored-by: silverbullet233 <[email protected]>
silverbullet233 added a commit that referenced this pull request Mar 11, 2025
… (#56740)

Signed-off-by: silverbullet233 <[email protected]>
Co-authored-by: eyes_on_me <[email protected]>
Co-authored-by: silverbullet233 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants