Skip to content

[Enhancement] Fix some mv related noisy logs #56672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2025
Merged

[Enhancement] Fix some mv related noisy logs #56672

merged 1 commit into from
Mar 7, 2025

Conversation

LiShuMing
Copy link
Contributor

@LiShuMing LiShuMing commented Mar 6, 2025 •
edited
Loading

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@LiShuMing LiShuMing requested review from a team as code owners March 6, 2025 10:01
@LiShuMing LiShuMing force-pushed the fix_mv_restart_speed branch from 6037702 to c1235a0 Compare March 7, 2025 01:48
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 7, 2025

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025

[FE Incremental Coverage Report]

✅ pass : 26 / 31 (83.87%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/CachingMvPlanContextBuilder.java 5 9 55.56% [239, 255, 311, 312]
🔵 com/starrocks/catalog/MaterializedView.java 19 20 95.00% [856]
🔵 com/starrocks/scheduler/TaskRunScheduler.java 2 2 100.00% []

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@LiShuMing LiShuMing merged commit a5978c6 into StarRocks:main Mar 7, 2025
59 checks passed
@LiShuMing LiShuMing deleted the fix_mv_restart_speed branch March 7, 2025 06:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025

@Mergifyio backport branch-3.3

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025

@Mergifyio backport branch-3.4

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 7, 2025 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 7, 2025 •
edited
Loading

backport branch-3.4

✅ Backports have been created

@github-actions github-actions bot added the 3.4 label Mar 7, 2025
mergify bot pushed a commit that referenced this pull request Mar 7, 2025
@LiShuMing @mergify
[Enhancement] Fix some mv related noisy logs (#56672)
eb3f3c2 
Signed-off-by: shuming.li <[email protected]>
(cherry picked from commit a5978c6)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/catalog/MaterializedView.java
@mergify mergify bot mentioned this pull request Mar 7, 2025
Merged
18 tasks
mergify bot pushed a commit that referenced this pull request Mar 7, 2025
@LiShuMing @mergify
[Enhancement] Fix some mv related noisy logs (#56672)
082d5cb 
Signed-off-by: shuming.li <[email protected]>
(cherry picked from commit a5978c6)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/catalog/MaterializedView.java
@mergify mergify bot mentioned this pull request Mar 7, 2025
Merged
18 tasks
wanpengfei-git pushed a commit that referenced this pull request Mar 7, 2025
@mergify @LiShuMing
[Enhancement] Fix some mv related noisy logs (backport #56672) (#56700)
e9fea88 
Signed-off-by: shuming.li <[email protected]>
Co-authored-by: shuming.li <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Mar 7, 2025
@mergify @LiShuMing
[Enhancement] Fix some mv related noisy logs (backport #56672) (#56699)
291b3c2 
Signed-off-by: shuming.li <[email protected]>
Co-authored-by: shuming.li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satanson satanson satanson approved these changes

@HangyuanLiu HangyuanLiu HangyuanLiu approved these changes

@stephen-shelby stephen-shelby stephen-shelby approved these changes

Assignees

@LiShuMing LiShuMing

Labels
3.3-merged 3.4-merged 3.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LiShuMing @satanson @HangyuanLiu @stephen-shelby