[BugFix] fix concat_ws(',', 1, NULL) incorrect result when last element is NULL #56384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt is NULL Signed-off-by: kaijian.ding <[email protected]>
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rewrite/ScalarOperatorFunctions.java
Show resolved
Hide resolved
kangkaisen
previously approved these changes
Feb 28, 2025
Seaven
reviewed
Feb 28, 2025
| final StringBuilder resultBuilder = new StringBuilder(); | ||
| for (int i = 0; i < values.length - 1; i++) { | ||
| if (values[i].isNull()) { | ||
| boolean first = true; |
There was a problem hiding this comment.
values.stream().filter(v -> !v.isNull()).map(v -> value.getVarchar()).collect(Collection.join(separator));
Signed-off-by: kaijian.ding <[email protected]>
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 6 / 6 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Seaven
approved these changes
Feb 28, 2025
kangkaisen
approved these changes
Mar 3, 2025
|
@Mergifyio backport branch-3.3 |
|
@Mergifyio backport branch-3.2 |
|
@Mergifyio backport branch-3.4 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 3, 2025
…nt is NULL (#56384) Signed-off-by: kaijian.ding <[email protected]> (cherry picked from commit 9b56f66)
mergify bot
pushed a commit
that referenced
this pull request
Mar 3, 2025
…nt is NULL (#56384) Signed-off-by: kaijian.ding <[email protected]> (cherry picked from commit 9b56f66)
mergify bot
pushed a commit
that referenced
this pull request
Mar 3, 2025
…nt is NULL (#56384) Signed-off-by: kaijian.ding <[email protected]> (cherry picked from commit 9b56f66)
This was referenced Mar 3, 2025
stephen-shelby
pushed a commit
to stephen-shelby/starrocks
that referenced
this pull request
Mar 3, 2025
…nt is NULL (StarRocks#56384) Signed-off-by: kaijian.ding <[email protected]>
dyp12
pushed a commit
to dyp12/starrocks
that referenced
this pull request
Mar 5, 2025
…nt is NULL (StarRocks#56384) Signed-off-by: kaijian.ding <[email protected]> Signed-off-by: 00193254 <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Mar 22, 2025
…nt is NULL (backport #56384) (#56455) Co-authored-by: kaijianding <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Mar 22, 2025
…nt is NULL (backport #56384) (#56456) Co-authored-by: kaijianding <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Mar 22, 2025
…nt is NULL (backport #56384) (#56454) Co-authored-by: kaijianding <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
concat_ws(',', 1, NULL)is1,the correct result should be
1What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
Checklist:
Bugfix cherry-pick branch check: