[Enhancement] Use input column statistics for computing IF min/max statistics #55922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: m-selmi <[email protected]>
m-selmi
force-pushed
the
enhance-if-function-statistics
branch
from
25f38b3 to
20f9408
Compare
|
|
|
please fix failed fe ut |
Seaven
previously approved these changes
Feb 21, 2025
stephen-shelby
previously approved these changes
Feb 21, 2025
Signed-off-by: m-selmi <[email protected]>
murphyatwork
approved these changes
Feb 24, 2025
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 5 / 5 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
stephen-shelby
approved these changes
Mar 3, 2025
|
@Mergifyio backport branch-3.4 |
|
@Mergifyio backport branch-3.3 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 3, 2025
…atistics (#55922) Signed-off-by: m-selmi <[email protected]> (cherry picked from commit 3618427)
18 tasks
mergify bot
pushed a commit
that referenced
this pull request
Mar 3, 2025
…atistics (#55922) Signed-off-by: m-selmi <[email protected]> (cherry picked from commit 3618427)
18 tasks
stephen-shelby
pushed a commit
to stephen-shelby/starrocks
that referenced
this pull request
Mar 3, 2025
…atistics (StarRocks#55922) Signed-off-by: m-selmi <[email protected]>
dyp12
pushed a commit
to dyp12/starrocks
that referenced
this pull request
Mar 5, 2025
…atistics (StarRocks#55922) Signed-off-by: m-selmi <[email protected]> Signed-off-by: 00193254 <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Mar 19, 2025
…atistics (backport #55922) (#56458) Co-authored-by: Hechem Selmi <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Mar 19, 2025
…atistics (backport #55922) (#56459) Co-authored-by: Hechem Selmi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Currently the IF function uses the
Double.NEGATIVE_INFINITYandDouble.POSITIVE_INFINITYas its min value and max value estimation. This is not ideal for predicate selectivity evaluation and can be easily improved.What I'm doing:
Since
if(expr1,expr2,expr3)returns values from eitherexpr2orexpr3we can use their min and max values to better estimate the output.For example for
IF(expr1,1,2)we can set the min value to 1 and the max value to 2.What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: