Skip to content

[Enhancement] Support Paimon manifest cache #55788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Conversation

mxdzs0612
Copy link
Contributor

@mxdzs0612 mxdzs0612 commented Feb 11, 2025

Why I'm doing:

Paimon enables CachingCatalog by default from 0.9.0. This PR optimizes Paimon metadata cache usage, default params are as follows:

        // cache expire time, set to 2h
        this.paimonOptions.set("cache.expiration-interval", "7200s");
        // max num of cached partitions of a Paimon catalog
        this.paimonOptions.set("cache.partition.max-num", "1000");
        // max size of cached manifest files, 10m means cache all since files usually no more than 8m
        this.paimonOptions.set("cache.manifest.small-file-threshold", "10m");
        // max size of memory manifest cache uses
        this.paimonOptions.set("cache.manifest.small-file-memory", "1g");

Users can change this options by adding propeties like paimon.option.xxxx when creating the paimon catalog.

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@mxdzs0612
Copy link
Contributor Author

Waiting for #55785 to be merged first.

@mxdzs0612 mxdzs0612 changed the title [WIP][Enhancement] Support Paimon manifest cache [Enhancement] Support Paimon manifest cache Feb 25, 2025
@mxdzs0612 mxdzs0612 marked this pull request as ready for review March 6, 2025 03:09
@mxdzs0612 mxdzs0612 requested review from a team as code owners March 6, 2025 03:09
@mxdzs0612 mxdzs0612 force-pushed the cache branch 6 times, most recently from f0b9017 to 638bdff Compare March 10, 2025 08:51
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 81 / 96 (84.38%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/connector/hive/ConnectorTableMetadataProcessor.java 30 40 75.00% [179, 180, 194, 196, 197, 198, 199, 200, 207, 208]
🔵 com/starrocks/connector/paimon/PaimonMetadata.java 39 44 88.64% [169, 637, 638, 647, 648]
🔵 com/starrocks/common/Config.java 1 1 100.00% []
🔵 com/starrocks/catalog/PaimonTable.java 2 2 100.00% []
🔵 com/starrocks/server/GlobalStateMgr.java 1 1 100.00% []
🔵 com/starrocks/connector/paimon/PaimonConnector.java 8 8 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@miomiocat miomiocat enabled auto-merge (squash) March 11, 2025 06:18
@miomiocat miomiocat merged commit bc8e49c into StarRocks:main Mar 11, 2025
58 of 59 checks passed
Copy link

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Mar 11, 2025
Copy link
Contributor

mergify bot commented Mar 11, 2025

backport branch-3.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 11, 2025
Signed-off-by: Jiao Mingye <[email protected]>
(cherry picked from commit bc8e49c)
@mxdzs0612 mxdzs0612 deleted the cache branch March 11, 2025 07:37
mxdzs0612 added a commit to mxdzs0612/starrocks that referenced this pull request Mar 11, 2025
mxdzs0612 added a commit to mxdzs0612/starrocks that referenced this pull request Mar 12, 2025
smartlxh pushed a commit that referenced this pull request Mar 12, 2025
wanpengfei-git pushed a commit that referenced this pull request Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants