Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix incorrect part of compaction profile #54678

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

starrocks-xupeng
Copy link
Contributor

@starrocks-xupeng starrocks-xupeng commented Jan 3, 2025

Why I'm doing:

What I'm doing:

in_queue_time_sec is 0 when it is actually not sometimes.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

kevincai
kevincai previously approved these changes Jan 3, 2025
@starrocks-xupeng starrocks-xupeng changed the title [BugFix] fix missing part of compaction profile [BugFix] fix incorrect part of compaction profile Jan 3, 2025
wyb
wyb previously approved these changes Jan 3, 2025
@wyb wyb enabled auto-merge (squash) January 3, 2025 09:04
auto-merge was automatically disabled January 3, 2025 09:07

Head branch was pushed to by a user without write access

@starrocks-xupeng starrocks-xupeng dismissed stale reviews from wyb and kevincai via 84224f1 January 3, 2025 09:07
Copy link

github-actions bot commented Jan 7, 2025

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Jan 7, 2025

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Jan 7, 2025

[BE Incremental Coverage Report]

pass : 6 / 6 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/lake/compaction_task.cpp 1 1 100.00% []
🔵 be/src/storage/lake/compaction_task_context.cpp 5 5 100.00% []

@murphyatwork murphyatwork merged commit 0a59530 into StarRocks:main Jan 7, 2025
41 checks passed
Copy link

github-actions bot commented Jan 7, 2025

@Mergifyio backport branch-3.4

Copy link

github-actions bot commented Jan 7, 2025

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.4 label Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

@Mergifyio backport branch-3.2

Copy link
Contributor

mergify bot commented Jan 7, 2025

backport branch-3.4

✅ Backports have been created

Copy link
Contributor

mergify bot commented Jan 7, 2025

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Jan 7, 2025

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 7, 2025
Signed-off-by: starrocks-xupeng <[email protected]>
(cherry picked from commit 0a59530)
mergify bot pushed a commit that referenced this pull request Jan 7, 2025
Signed-off-by: starrocks-xupeng <[email protected]>
(cherry picked from commit 0a59530)
mergify bot pushed a commit that referenced this pull request Jan 7, 2025
Signed-off-by: starrocks-xupeng <[email protected]>
(cherry picked from commit 0a59530)

# Conflicts:
#	be/src/storage/lake/compaction_task.cpp
#	be/src/storage/lake/compaction_task_context.cpp
#	be/src/storage/lake/compaction_task_context.h
wanpengfei-git pushed a commit that referenced this pull request Jan 7, 2025
wanpengfei-git pushed a commit that referenced this pull request Jan 7, 2025
zhangyifan27 pushed a commit to zhangyifan27/starrocks that referenced this pull request Feb 10, 2025
smartlxh pushed a commit to smartlxh/starrocks that referenced this pull request Feb 24, 2025
wxl24life pushed a commit to wxl24life/starrocks that referenced this pull request Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants