Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] olap view should not participate in MV processing logic #52989

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

stephen-shelby
Copy link
Contributor

@stephen-shelby stephen-shelby commented Nov 19, 2024

Why I'm doing:

reproduce case:

create table t0 (k1 string, k2 string, k3 string);
create table t1 (k1 string, k2 string, k3 string);
create view v_l as select k1, k2 as k22, k3 as k33;
create view v_r as select k1, k2 as k222, k3 as k332;

select l.k1 from v_l l left join v_r r1 on l.k22=r1.k222 left join v_r r2 on trim(l.k33)=r2.k333;

error msg

com.starrocks.sql.common.StarRocksPlannerException: only found column statistics: {1: k1, 2: k2, 3: k3, 15: k3}, but missing statistic of col: 19: trim.

What I'm doing:

If the olap view does not have mv, the optimizer process will be polluted. like https://github.com/StarRocks/starrocks/blob/main/fe/fe-core/src/main/java/com/starrocks/sql/optimizer/Optimizer.java#L266

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@stephen-shelby stephen-shelby requested a review from a team as a code owner November 19, 2024 07:09
@github-actions github-actions bot added the 3.3 label Nov 19, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 4 / 4 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/MvRewritePreprocessor.java 4 4 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@stephen-shelby stephen-shelby enabled auto-merge (squash) November 19, 2024 09:34
@stephen-shelby stephen-shelby merged commit 04ad32a into StarRocks:main Nov 19, 2024
55 of 60 checks passed
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Nov 19, 2024
Copy link
Contributor

mergify bot commented Nov 19, 2024

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 19, 2024
wanpengfei-git pushed a commit that referenced this pull request Nov 19, 2024
Smith-Cruise pushed a commit to Smith-Cruise/starrocks that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants