Skip to content

[Enhancement] invalidate table cache after hive table do not need to refresh by ConnectorTableMetadataProcessor #37549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

Youngwb
Copy link
Contributor

@Youngwb Youngwb commented Dec 21, 2023

Why I'm doing:
Hive table support refresh meta cache automatically,it will stop refresh the table meta cahce which has long time not query on it,but the table cache still exist, it could be outdated
What I'm doing:
when the table cache do not need to refresh, invalidate the table meta cache
Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

…refresh by ConnectorTableMetadataProcessor

Signed-off-by: Youngwb <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

[FE Incremental Coverage Report]

pass : 6 / 6 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/connector/hive/CachingHiveMetastore.java 6 6 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@Youngwb Youngwb merged commit d24c364 into StarRocks:main Dec 22, 2023
@Youngwb Youngwb deleted the invalidate_cache branch December 22, 2023 06:12
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Dec 22, 2023
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Dec 22, 2023
Copy link

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Dec 22, 2023
Copy link

@Mergifyio backport branch-2.5

Copy link
Contributor

mergify bot commented Dec 22, 2023

backport branch-3.2

✅ Backports have been created

@github-actions github-actions bot removed the 2.5 label Dec 22, 2023
Copy link
Contributor

mergify bot commented Dec 22, 2023

backport branch-3.1

✅ Backports have been created

Copy link
Contributor

mergify bot commented Dec 22, 2023

backport branch-3.0

✅ Backports have been created

Copy link
Contributor

mergify bot commented Dec 22, 2023

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 22, 2023
…refresh by ConnectorTableMetadataProcessor (#37549)

Signed-off-by: Youngwb <[email protected]>
(cherry picked from commit d24c364)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/connector/hive/CachingHiveMetastoreTest.java
mergify bot pushed a commit that referenced this pull request Dec 22, 2023
…refresh by ConnectorTableMetadataProcessor (#37549)

Signed-off-by: Youngwb <[email protected]>
(cherry picked from commit d24c364)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/connector/hive/CachingHiveMetastoreTest.java
mergify bot pushed a commit that referenced this pull request Dec 22, 2023
…refresh by ConnectorTableMetadataProcessor (#37549)

Signed-off-by: Youngwb <[email protected]>
(cherry picked from commit d24c364)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/connector/hive/CachingHiveMetastoreTest.java
mergify bot pushed a commit that referenced this pull request Dec 22, 2023
…refresh by ConnectorTableMetadataProcessor (#37549)

Signed-off-by: Youngwb <[email protected]>
(cherry picked from commit d24c364)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/connector/hive/CachingHiveMetastoreTest.java
Youngwb added a commit that referenced this pull request Dec 22, 2023
…er hive table do not need to refresh by ConnectorTableMetadataProcessor (#37635)

Signed-off-by: Youngwb <[email protected]>
mergify bot pushed a commit that referenced this pull request Dec 22, 2023
…er hive table do not need to refresh by ConnectorTableMetadataProcessor (#37635)

Signed-off-by: Youngwb <[email protected]>
(cherry picked from commit bca983c)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/connector/hive/CachingHiveMetastoreTest.java
Youngwb added a commit that referenced this pull request Dec 22, 2023
…er hive table do not need to refresh by ConnectorTableMetadataProcessor (#37656)

Signed-off-by: Youngwb <[email protected]>
Youngwb added a commit that referenced this pull request Dec 22, 2023
…er hive table do not need to refresh by ConnectorTableMetadataProcessor (#37666)

Signed-off-by: Youngwb <[email protected]>
Youngwb added a commit that referenced this pull request Dec 22, 2023
…er hive table do not need to refresh by ConnectorTableMetadataProcessor (#37668)

Signed-off-by: Youngwb <[email protected]>
Zhangg7723 pushed a commit to Zhangg7723/starrocks that referenced this pull request Dec 26, 2023
…refresh by ConnectorTableMetadataProcessor (StarRocks#37549)

Signed-off-by: Youngwb <[email protected]>
Signed-off-by: 张敢 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants