SPIGOT-8024, #3811: Add versioned chat serialization

[md-5]

See

• https://hub.spigotmc.org/jira/browse/SPIGOT-8024
• Chat components serialization should be version specific #3811

[md-5]

cc/ @Janmm14

[Outfluencer]

Shouldn't we also deserialize by version?

For example here?

BungeeCord/chat/src/main/java/net/md_5/bungee/chat/BaseComponentSerializer.java

Line 37 in 6ab9856

JsonObject clickEvent;

we should do it like this right?

JsonObject clickEvent = serializer.getVersion() == ChatVersion.V1_21_5 ? object.getAsJsonObject( "click_event" ) : object.getAsJsonObject( "clickEvent" );

if ( clickEvent != null )
{
    ClickEvent.Action action = ClickEvent.Action.valueOf( clickEvent.get( "action" ).getAsString().toUpperCase( Locale.ROOT ) );
    if ( serializer.getVersion() == ChatVersion.V1_21_5 )
    {

[NEZNAMY]

It would be great to also translate ChatColor to nearest legacy color for <1.16 players.

[md-5]

Shouldn't we also deserialize by version?

For example here?

BungeeCord/chat/src/main/java/net/md_5/bungee/chat/BaseComponentSerializer.java

Line 37 in 6ab9856

JsonObject clickEvent;

we should do it like this right?

JsonObject clickEvent = serializer.getVersion() == ChatVersion.V1_21_5 ? object.getAsJsonObject( "click_event" ) : object.getAsJsonObject( "clickEvent" );

if ( clickEvent != null )
{
    ClickEvent.Action action = ClickEvent.Action.valueOf( clickEvent.get( "action" ).getAsString().toUpperCase( Locale.ROOT ) );
    if ( serializer.getVersion() == ChatVersion.V1_21_5 )
    {

I think it's OK for the moment to have the deserialization be universal (especially for compatibility).

It would be great to also translate ChatColor to nearest legacy color for <1.16 players.

Not really related to this PR

[Outfluencer]

do hover events work in server list motd?
If so we should probably also have a second PingHandler json for the new version, if not its probably okay if we just ignore it as it won't be displayed anyway

[md-5]

I'm not sure - can you check please?

[Outfluencer]

Yes i'll check now

[Outfluencer]

Adding a hover event to the motd components clears the full motd on 1.21.4
on old versions like 1.8.9 it just does nothing
But in both cases no hover text is displayed

And click event does not work at all

this is the json that makes the motd disabear

{"version":{"name":"BungeeCord 1.8.x-1.21.x","protocol":769},"players":{"max":1,"online":0},"description":{"hoverEvent":{"action":"show_text","contents":{"value":"HALLLOOO"}},"extra":[{"color":"dark_blue","text":"Another Bungee server"}],"text":""},"modinfo":{"type":"FML","modList":[]}}

I think we can it ignore it for now

[Janmm14]

Codewise I do not see anything bad. Didn't test it tho.