Ensure listType is set to compound tag when wrapping tags #3794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a unit test please? |
|
Done. Do you know if wrapping elements in compound tags works on every Minecraft version bungee supports or should we add code to make sure that only happens if there are actually different types in the list? |
|
Would probably be better to do if only different types to simplify the nbt, but I'm not sure |
- Only wrap items in a compound tag if different types are used - Support mixed lists with bytes, ints and longs
|
Done. I also fixed mixed lists that start with a byte, int or long which previously were always their native arrays even if they included other types |
md-5
pushed a commit
that referenced
this pull request
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3793