Expose ChannelInitializerHolder in protocol module #3776
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think if we're going to go down this path it should be a proper factory design |
Can you tell me what a proper factory design looks like for you? |
…to make-channel-init-accessable # Conflicts: # protocol/src/main/java/net/md_5/bungee/protocol/holder/ChannelInitializerHolder.java # proxy/src/main/java/net/md_5/bungee/netty/PipelineUtils.java
md-5
reviewed
Feb 8, 2025
| * Holds the channel initializer for incoming connections | ||
| */ | ||
| @Getter | ||
| private static BungeeChannelInitializer frontendHolder; |
There was a problem hiding this comment.
Should i put the non static objects into BungeeCord.java and make them accessable via
ProxyServer.getInstance().unsafe()?
md-5
approved these changes
Feb 13, 2025
md-5
pushed a commit
that referenced
this pull request
Feb 15, 2025
|
Thanks |
|
Please give plugin developers a way to replace the channel initializer. Making everything private and final might look good, but makes using reflection for injection a terrible experience. E.g., add |
FlorianMichael
added a commit
to FlorianMichael/BungeeCord
that referenced
this pull request
Mar 5, 2025
Third party plugins using the API provided in SpigotMC#3776 need to reorder their own pipeline elements as soon as the compression is enabled, which is currently not possible (at least not in a proper way without delaying packets). This PR adds a simple netty signal which can be used for this very use-case and is provided similar in other proxy/server projects as well.
NixNux123
added a commit
to NixNux123/connect-java
that referenced
this pull request
Apr 4, 2025
…e new [BungeeCord ChannelInitializer API](SpigotMC/BungeeCord#3776) - Updated the `bungeecord-proxy` dependency to 1.21.-R0.1-SNAPSHOT - Added a message when running an outdated bungeecord version (that doesn't support the new ChannelInitializer API) *Kept one and ported one funny comment* **Users are advised to upgrade their bungeecord proxies!**
robinbraemer
pushed a commit
to minekube/connect-java
that referenced
this pull request
Apr 4, 2025
* - Ported some changes from geyser/floodgate where they switched to the new [BungeeCord ChannelInitializer API](SpigotMC/BungeeCord#3776) - Updated the `bungeecord-proxy` dependency to 1.21.-R0.1-SNAPSHOT - Added a message when running an outdated bungeecord version (that doesn't support the new ChannelInitializer API) *Kept one and ported one funny comment* **Users are advised to upgrade their bungeecord proxies!** * Updated the pullrequest workflow to use upload-artifact@v4 instead of the deprecated v2 * Forgot to delete an old util file that is no longer needed because of the BungeeCord ChannelInitializer API * Removed an unused class related to skins that caused an error on Java 8 * Upgraded push request workflow to java 17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the protocol module already exposes netty, i think its the best to also put this ChannelInitializerHolder here.
It allows for big plugins like Geyser and ViaVersion to access and modify the channel initializers of the serverchild and backendconnector.
This PR makes the development of software that modifies the networking much easier
I tried to impl it as simple as possible, and expose only the ChannelInitilizers in a nice way