SQSCANGHA-89 Attempt to fix command injection #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryju
force-pushed
the
jh/try_fix_command_injection
branch
6 times, most recently
from
87219cb to
9207a35
Compare
It is unlikely to be a real concern, since an attacker having the possibility to edit a pipeline can easily execute any command, but at least our step won't be involved
henryju
force-pushed
the
jh/try_fix_command_injection
branch
from
9207a35 to
c999cf3
Compare
|
I have ran through the test cases on a pipeline they look good: |
csaba-feher-sonarsource
approved these changes
Apr 29, 2025
luketainton
pushed a commit
to luketainton/roboluke-tasks
that referenced
this pull request
May 6, 2025
…0 (#349) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [SonarSource/sonarqube-scan-action](https://github.com/SonarSource/sonarqube-scan-action) | action | minor | `v5.1.0` -> `v5.2.0` | --- ### Release Notes <details> <summary>SonarSource/sonarqube-scan-action (SonarSource/sonarqube-scan-action)</summary> ### [`v5.2.0`](https://github.com/SonarSource/sonarqube-scan-action/releases/tag/v5.2.0) [Compare Source](SonarSource/sonarqube-scan-action@v5.1.0...v5.2.0) ##### What's Changed - SQSCANGHA-90 remove mend dead conf by [@​pierre-guillot-gh](https://github.com/pierre-guillot-gh) in SonarSource/sonarqube-scan-action#184 - SQSCANGHA-89 Attempt to fix command injection by [@​henryju](https://github.com/henryju) in SonarSource/sonarqube-scan-action#186 - SQSCANGHA-93 Fix madhead/semver-utils' version by [@​csaba-feher-sonarsource](https://github.com/csaba-feher-sonarsource) in SonarSource/sonarqube-scan-action#187 - SQSCANGHA-94 Update version update logic by [@​csaba-feher-sonarsource](https://github.com/csaba-feher-sonarsource) in SonarSource/sonarqube-scan-action#188 - SQSCANGHA-92 Validate scanner version by [@​csaba-feher-sonarsource](https://github.com/csaba-feher-sonarsource) in SonarSource/sonarqube-scan-action#189 **Full Changelog**: SonarSource/sonarqube-scan-action@v5...v5.2.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC4wLjkiLCJ1cGRhdGVkSW5WZXIiOiI0MC4wLjkiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbInR5cGUvZGVwZW5kZW5jaWVzIl19--> Reviewed-on: https://git.tainton.uk/repos/roboluke/pulls/349 Co-authored-by: Renovate [BOT] <[email protected]> Co-committed-by: Renovate [BOT] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQSCANGHA-89