Skip to content

BUG: Consolidate extension metadata with one set in extension build-system #2039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

jcfr
Copy link
Member

@jcfr jcfr commented Apr 22, 2024

No description provided.

@jcfr jcfr requested a review from jamesobutler April 22, 2024 22:59
@jcfr
Copy link
Member Author

jcfr commented Apr 22, 2024

For reference, here is the list of pull requests updating metadata in the corresponding extension build-system:

…ystem

This changes were manually crafted by comparing the values hard-coded in the
s4ext and the one hard-coded in the corresponding CMake file.
@jcfr jcfr force-pushed the consolidate-extension-metadata branch from a5839d4 to f218427 Compare April 22, 2024 23:07
@@ -6,9 +6,9 @@ depends NA

build_subdirectory inner-build

homepage https://github.com/SlicerDMRI/whitematteranalysis
homepage https://github.com/SlicerDMRI/SlicerWMA#readme
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears the SlicerWMA repo was recently named to “SlicerWMA-OLD”.
https://github.com/SlicerDMRI/SlicerWMA-OLD

@jhlegarreta Is this an indication that SlicerDMRI wants to remove the SlicerWMA extension from the Slicer extensions index? Or will there be a new repo for SlicerWMA?

Copy link
Contributor

@jhlegarreta jhlegarreta Apr 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies James, but I was/am not aware of the potential related conversations: @jcfr is probably in a better position to answer the question: SlicerDMRI/SlicerWMA#11

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhlegarreta Do you happen to know who renamed the repository from SlicerWMA to SlicerWMA-OLD? The issue I created is intended to help understand the rational and provide some clarification.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I thought it was you JC. Really sorry for having assumed that. It was not me, and I had no discussion about renaming it with anybody: I only realized about the renaming after I got notified by GitHub about the issue you opened, and thus I mistakenly linked both things.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ljod and I have been working with @zhangfanmark to update this. So this extension (SlicerWMA) is being deprecated in favor of https://github.com/SlicerDMRI/SlicerTractParcellation which is still being worked on #2037

@jcfr
Copy link
Member Author

jcfr commented Apr 23, 2024

In the meantime, I will move forward with the integration.

@jcfr jcfr merged commit f8f2aad into Slicer:main Apr 23, 2024
3 checks passed
@jcfr jcfr deleted the consolidate-extension-metadata branch April 23, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants