Skip to content

[QUAR-801][BpkOverlay] Update video overlay to align with heavy overlay design #3787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kirstybryce
Copy link
Contributor

@kirstybryce kirstybryce commented Apr 8, 2025

Jira: https://skyscanner.atlassian.net/browse/QUAR-801

In January we added the video overlay style for the BpkOverlay component in #3717 to be used in the homepage video advert POC. In the next version of the ad we have to align the video overlay with the backpack heavy overlay design.

We're renaming the overlay type from video to heavy, which would normally be a breaking change release, but since it's only used in one place, we can make sure to update the overlay name there after doing the next Backpack release.

Before After
Screenshot 2025-04-08 at 22 15 01 Screenshot 2025-04-08 at 22 25 25

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [Clover-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Accessibility tests
    • The following checks were performed:
      • Ability to navigate using a keyboard only
      • Zoom functionality (Deque University explanation):
        • The page SHOULD be functional AND readable when only the text is magnified to 200% of its initial size
        • Pages must reflow as zoom increases up to 400% so that content continues to be presented in only one column i.e. Content MUST NOT require scrolling in two directions (both vertically and horizontally)
      • Ability to navigate using a screen reader only
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@kirstybryce kirstybryce added the minor Non breaking change label Apr 8, 2025
@skyscanner-backpack-bot
Copy link

Visit https://backpack.github.io/storybook-prs/3787 to see this build running in a browser.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • packages/bpk-component-overlay/src/BpkOverlay.module.scss: Language not supported
  • packages/bpk-component-overlay/src/snapshots/BpkOverlay-test.tsx.snap: Language not supported

@skyscanner-backpack-bot
Copy link

Visit https://backpack.github.io/storybook-prs/3787 to see this build running in a browser.

@skyscanner-backpack-bot
Copy link

Warnings
⚠️

Package source files (e.g. packages/package-name/src/Component.tsx) were updated, but type files weren't. Have you checked that no types have changed?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against 66e9002

&-top {
background: linear-gradient(
180deg,
rgba(tokens.$bpk-text-primary-day, 0.45) 0%,
rgba(tokens.$bpk-text-primary-day, 0) 40%,
rgba(tokens.$bpk-text-primary-day, 0.15) 60%,
rgba(tokens.$bpk-text-primary-day, 0.05) 80%,
rgba(tokens.$bpk-text-primary-day, 0) 100%
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kirstybryce I noticed you changed this. I didn't see the Percy has a failure due to the color change. Does it cause a visual change? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it does, it might not be a big enough change to be picked up by percy though 🤔 you can see in the screenshots the visual differences. It's only extending dark part of the gradient to take up more of the height, it's the same colour and opacity otherwise

Copy link
Contributor

@Faye-Xiao Faye-Xiao Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's very interesting. I'll take a look at the Percy-related document later.
The code looks good to me!

Copy link
Contributor

@Faye-Xiao Faye-Xiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Faye-Xiao Faye-Xiao merged commit fc81050 into main Apr 10, 2025
9 checks passed
@Faye-Xiao Faye-Xiao deleted the QUAR-801_update-video-overlay-to-align-with-heavy-overlay-design branch April 10, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Non breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants