-
Notifications
You must be signed in to change notification settings - Fork 205
[QUAR-801][BpkOverlay] Update video overlay to align with heavy overlay design #3787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QUAR-801][BpkOverlay] Update video overlay to align with heavy overlay design #3787
Conversation
Visit https://backpack.github.io/storybook-prs/3787 to see this build running in a browser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (2)
- packages/bpk-component-overlay/src/BpkOverlay.module.scss: Language not supported
- packages/bpk-component-overlay/src/snapshots/BpkOverlay-test.tsx.snap: Language not supported
Visit https://backpack.github.io/storybook-prs/3787 to see this build running in a browser. |
&-top { | ||
background: linear-gradient( | ||
180deg, | ||
rgba(tokens.$bpk-text-primary-day, 0.45) 0%, | ||
rgba(tokens.$bpk-text-primary-day, 0) 40%, | ||
rgba(tokens.$bpk-text-primary-day, 0.15) 60%, | ||
rgba(tokens.$bpk-text-primary-day, 0.05) 80%, | ||
rgba(tokens.$bpk-text-primary-day, 0) 100% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kirstybryce I noticed you changed this. I didn't see the Percy has a failure due to the color change. Does it cause a visual change? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it does, it might not be a big enough change to be picked up by percy though 🤔 you can see in the screenshots the visual differences. It's only extending dark part of the gradient to take up more of the height, it's the same colour and opacity otherwise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's very interesting. I'll take a look at the Percy-related document later.
The code looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Jira: https://skyscanner.atlassian.net/browse/QUAR-801
In January we added the video overlay style for the BpkOverlay component in #3717 to be used in the homepage video advert POC. In the next version of the ad we have to align the video overlay with the backpack heavy overlay design.
We're renaming the overlay type from
video
toheavy
, which would normally be a breaking change release, but since it's only used in one place, we can make sure to update the overlay name there after doing the next Backpack release.Remember to include the following changes:
[Clover-123][BpkButton] Updating the colour
README.md
(If you have created a new component)README.md