Skip to content

[PANGOO-2905][BpkCheckbox]Checkbox With SVG #3774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Mar 27, 2025
Merged

[PANGOO-2905][BpkCheckbox]Checkbox With SVG #3774

Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
cd52b6a
PANGOO-2905/checkbox-with-svg
Mar 21, 2025
2f95367
disable check
Mar 21, 2025
d3c571b
todo
Mar 21, 2025
cb47e84
Merge branch 'main' into PANGOO-2905/checkbox
senzg Mar 21, 2025
c92d7d8
Merge branch 'main' into PANGOO-2905/checkbox
olliecurtis Mar 24, 2025
26d440c
Merge branch 'main' into PANGOO-2905/checkbox
senzg Mar 25, 2025
f5e4880
double svgs
Mar 26, 2025
e44ce50
Adjust the size
Mar 26, 2025
5d3824b
Final Version 1.0.0
Mar 26, 2025
2e7ccca
Merge branch 'main' into PANGOO-2905/checkbox
senzg Mar 26, 2025
3ef54e5
Final Version 1.0.1
Mar 26, 2025
2fa8d2e
Merge branch 'PANGOO-2905/checkbox' of https://github.com/Skyscanner/…
Mar 26, 2025
2444158
mistake
Mar 26, 2025
07945ce
Merge branch 'main' into PANGOO-2905/checkbox
senzg Mar 26, 2025
6605eba
mistake
Mar 26, 2025
57a8fb7
Merge branch 'PANGOO-2905/checkbox' of https://github.com/Skyscanner/…
Mar 26, 2025
bc1b1d9
Merge branch 'PANGOO-2905/checkbox' of https://github.com/Skyscanner/…
Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 5 additions & 26 deletions packages/bpk-mixins/_forms.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,34 +627,13 @@
/// @include bpk-checkbox__checkmark();
/// }
@mixin bpk-checkbox__checkmark {
&::before,
&::after {
position: absolute;
content: '';
transform: rotate(45deg);
border-radius: $bpk-border-size-lg;
background-color: $bpk-text-primary-inverse-day;
}

&::before {
top: bpk-spacing-md() - $bpk-one-pixel-rem;
left: 0;
width: bpk-spacing-lg() / 3;
height: bpk-spacing-sm() - $bpk-one-pixel-rem;
}

&::after {
top: bpk-spacing-sm() / 2;
left: bpk-spacing-md() - $bpk-one-pixel-rem;
width: bpk-spacing-sm() - $bpk-one-pixel-rem;
height: bpk-spacing-md() + ($bpk-one-pixel-rem * 3);
}
background-image: url('data:image/svg+xml,%3Csvg%20width%3D%2213%22%20height%3D%229%22%20viewBox%3D%220%200%2013%209%22%20fill%3D%22none%22%20xmlns%3D%22http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%22%3E%3Cpath%20d%3D%22M2.35352%203.64648L5.5%207.5L11.5%201.5%22%20stroke%3D%22white%22%20stroke-width%3D%223%22%20stroke-linecap%3D%22round%22%20stroke-linejoin%3D%22round%22%2F%3E%3C%2Fsvg%3E');
background-repeat: no-repeat;
background-position: $bpk-one-pixel-rem center;
background-size: calc(100% - $bpk-one-pixel-rem * 2.5) auto;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note here: the design has confirmed with the backpack designer by @senzg


&:disabled {
&::before,
&::after {
background-color: $bpk-text-disabled-day;
}
background-image: url('data:image/svg+xml,%3Csvg%20width%3D%2213%22%20height%3D%229%22%20viewBox%3D%220%200%2013%209%22%20fill%3D%22none%22%20xmlns%3D%22http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%22%3E%3Cpath%20d%3D%22M2.35352%203.64648L5.5%207.5L11.5%201.5%22%20stroke%3D%22lightgrey%22%20stroke-width%3D%223%22%20stroke-linecap%3D%22round%22%20stroke-linejoin%3D%22round%22%2F%3E%3C%2Fsvg%3E');
}
}

Expand Down
Loading