Skip to content

DON-386: Add accessibility support to BPKNudger #1987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

yurareutskiy
Copy link
Contributor

@yurareutskiy yurareutskiy commented Jun 7, 2024

In the scope of improving feature tests of the traveller selector there is essential change for BPKNudger, which is using as a stepper component in TravellerSelector.

The problem is some small components like increment and decrement buttons are unavailable for clicking in UITests due to combining those elements into one Nudger accessibility element.

Those changes make smaller elements accessible without any changes for screen reader for actual accessibility users.

Remember to include the following changes:

If you are curious about how we review, please read through the code review guidelines

@yurareutskiy yurareutskiy added Accessibility minor Non breaking change labels Jun 7, 2024
@yurareutskiy yurareutskiy force-pushed the donburi/DON-386_feature_tests_for_traveller_selector branch from 6636684 to 987928f Compare June 7, 2024 03:04
@yurareutskiy yurareutskiy changed the title Donburi/don 386 feature tests for traveller selector DON-386: Add accessibility support to BPKNudger Jun 7, 2024
Copy link
Contributor

@frugoman frugoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@frugoman frugoman merged commit 2f65e6c into main Jun 7, 2024
14 checks passed
@frugoman frugoman deleted the donburi/DON-386_feature_tests_for_traveller_selector branch June 7, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility minor Non breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants